Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Sequoia's support for SDR peak brightness adjustment feature for third party HDR displays #3063

Closed
waydabber opened this issue Jun 10, 2024 · 3 comments
Assignees
Labels
done All tasks are completed enhancement New feature or request released Released
Milestone

Comments

@waydabber
Copy link
Owner

Third party displays in HDR mode works more like how XDR displays work and now use Apple's own brightness control API calls to use software control to adjust SDR brightness level. This makes a lot of sense for mini-LED and OLED displays.

This change causes some minor issues with BD as the app switches to Apple control, hiding the HDR toggle so the user can't switch back.

@waydabber waydabber added enhancement New feature or request in progress Implementing unreleased Not released yet in beta form labels Jun 10, 2024
@waydabber waydabber added this to the v2.3.5 milestone Jun 10, 2024
@waydabber waydabber self-assigned this Jun 10, 2024
@waydabber
Copy link
Owner Author

Note: as a workaround this can be enabled:

Screenshot 2024-06-10 at 23 48 34

@waydabber waydabber added done All tasks are completed and removed in progress Implementing labels Jun 11, 2024
@waydabber waydabber changed the title Add support for Sequoia's updated third-party HDR display support changes Add support for Sequoia's support for SDR peak brightness adjustment feature for third party HDR displays Jun 11, 2024
@waydabber
Copy link
Owner Author

The app will now use the new "SDR peak brightness adjustment control for HDR" (Control Center brightness slider for HDR displays) for combined brightness by default - the effect should be similar to how XDR displays work (especially if a proper mini-LED or OLED display is in use).

If the user enables "Allow DDC hardware brightness control in HDR mode" in Sequoia, the app will use DDC brightness for combined brightness control instead of the SDR peak brightness adjustment control (HDR brightness control) provided by macOS. The user can still adjust the SDR peak brightness in Control Center - these adjustments will influence the upscaling (if available) headroom provided by the app appropriately.

Screenshot 2024-06-11 at 21 46 20

@waydabber
Copy link
Owner Author

Related: #3065

@waydabber waydabber added pre-release available Released as beta version and removed unreleased Not released yet in beta form labels Jun 12, 2024
@waydabber waydabber added released Released and removed pre-release available Released as beta version labels Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done All tasks are completed enhancement New feature or request released Released
Projects
None yet
Development

No branches or pull requests

1 participant