New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statsdcc <-> Statsdcc Compatibility Enhancements #3

Merged
merged 13 commits into from Aug 11, 2017

Conversation

Projects
None yet
2 participants
@rrusso1982
Contributor

rrusso1982 commented Jul 28, 2017

These enhancements are designed to improve the "drop-in" replacement compatibility of statsdcc with statsd. A general overview of the changes are:

  • Metrics prefix: The ability to add a prefix to all metrics that are processed by the statsdcc instance. Ex: metricA.count -> prefix.metricsA.count
  • Metrics grouping: All metrics that go through statsdcc should be grouped by metrics type. These are counters, timers, gauges, and sets. Hence instead of producing the counter "metricA.count" it will produce "counters.metricA.count"
  • Timer percentiles: Statsdcc does support percentile calculations for timers however it does not produce the same set that statsd produces. By default it will produce upper_X for each percentile but for more compatibility with statsd it also needs to produce count_X, sum_X, and mean_X.

@sdomalap sdomalap merged commit 1f106c0 into wayfair:master Aug 11, 2017

@sdomalap

This comment has been minimized.

Show comment
Hide comment
@sdomalap

sdomalap Aug 11, 2017

Contributor

This looks good. We will likely make a few changes in order to put some if this new functionality behind parameters (i.e. Optional).

Contributor

sdomalap commented Aug 11, 2017

This looks good. We will likely make a few changes in order to put some if this new functionality behind parameters (i.e. Optional).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment