Add page_id as a parameter to getHomepagePromos since its needed often.

Move the getHomepagePromos method to the top of the styleguide repository file to mirror how the actual repository is.
waynestate · Sep 25, 2018 · 62f3191 · 62f3191
1 parent a4798b2
commit 62f3191
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 15 deletions.
diff --git a/app/Repositories/PromoRepository.php b/app/Repositories/PromoRepository.php
@@ -36,14 +36,14 @@ public function __construct(Connector $wsuApi, ParsePromos $parsePromos, Reposit
     /**
      * {@inheritdoc}
      */
-    public function getHomepagePromos()
+    public function getHomepagePromos(int $page_id = 0)
     {
         $group_reference = [
             123 => 'example',
         ];
 
         $group_config = [
-            'example' => 'first',
+            'example' => 'page_id:'.$page_id.'|randomize|first',
         ];
 
         $params = [

diff --git a/contracts/Repositories/PromoRepositoryContract.php b/contracts/Repositories/PromoRepositoryContract.php
@@ -9,5 +9,5 @@ interface PromoRepositoryContract
      *
      * @return array
      */
-    public function getHomepagePromos();
+    public function getHomepagePromos(int $page_id);
 }
diff --git a/styleguide/Repositories/PromoRepository.php b/styleguide/Repositories/PromoRepository.php
@@ -6,6 +6,17 @@
 
 class PromoRepository extends Repository
 {
+    /**
+     * {@inheritdoc}
+     */
+    public function getHomepagePromos(int $page_id = null)
+    {
+        return [
+            // Example Group
+            //'key' => app('Factories\YourFactory')->create(5),
+        ];
+    }
+
     /**
      * {@inheritdoc}
      */
@@ -80,15 +91,4 @@ public function getRequestData(array $data)
             'accordion_page' => $accordion,
         ];
     }
-
-    /**
-     * {@inheritdoc}
-     */
-    public function getHomepagePromos()
-    {
-        return [
-            // Example Group
-            //'key' => app('Factories\YourFactory')->create(5),
-        ];
-    }
 }
diff --git a/tests/Unit/Repositories/PromoRepositoryTest.php b/tests/Unit/Repositories/PromoRepositoryTest.php
@@ -180,7 +180,7 @@ public function getting_homepage_promos_should_return_array()
         $wsuApi->shouldReceive('sendRequest')->with('cms.promotions.listing', Mockery::type('array'))->once()->andReturn($return);
 
         // Get the promos
-        $promos = app('App\Repositories\PromoRepository', ['wsuApi' => $wsuApi])->getHomepagePromos();
+        $promos = app('App\Repositories\PromoRepository', ['wsuApi' => $wsuApi])->getHomepagePromos($this->faker->randomDigit);
 
         $this->assertTrue(is_array($promos));
     }