fixed insertRule() method error #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM and thx! |
ryodocx
pushed a commit
to ryodocx/t-rex-runner
that referenced
this pull request
Mar 18, 2019
fixed insertRule() method error
Janek20202
added a commit
to Janek20202/ddd
that referenced
this pull request
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, the insertRule() method used in the playIntro function wasn't working. My guess is that because it has a return value now (it must have changed recently), the code would exit out and never finish the rest of the playIntro() method. My code avoids the insertRule() method by creating a new style sheet, placing the keyframes rule in it, and then putting that stylesheet in the header of the index.html document. This seems to me to be in line with the original code, but in a way that functions properly. Let me know if you have any suggestions or different ways we can go about fixing this problem.