Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the search in the agents inventory table #5198

Closed
Tracked by #5316
Desvelao opened this issue Feb 7, 2023 · 2 comments · Fixed by #5196, #5345 or #5346
Closed
Tracked by #5316

Fix the search in the agents inventory table #5198

Desvelao opened this issue Feb 7, 2023 · 2 comments · Fixed by #5196, #5345 or #5346
Assignees
Labels
level/task Task issue type/bug Bug issue

Comments

@Desvelao
Copy link
Member

Desvelao commented Feb 7, 2023

Description

The search functionality for the tables from the Agents Inventory view do not search properly across the columns of the table, displaying search results that do not match with the search fields.

@Desvelao Desvelao added the type/bug Bug issue label Feb 7, 2023
@Desvelao Desvelao self-assigned this Feb 7, 2023
@Desvelao Desvelao linked a pull request Feb 7, 2023 that will close this issue
6 tasks
@Desvelao
Copy link
Member Author

Desvelao commented Feb 7, 2023

@Machi3mfl and I were researching this problem yesterday.

The first intention was to replace the component that includes a search bar with filters. We found some problems in the search bar related to the search query parameter, so we decided to keep the current search bar and change the search done in the API request. We will use the q query parameter to search in each field that is displayed in the table.

This solution can be found in #5196.

@asteriscos asteriscos changed the title Fix the seach in the agents inventory table Fix the search in the agents inventory table Feb 7, 2023
@Desvelao
Copy link
Member Author

In a meeting, we talked about this case. We want to replace the current search bar with the new one #4312 when it is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment