Fix the search in the agent inventory data tables #5196

Desvelao · 2023-02-06T17:22:35Z

Description

This pull request changes the query parameter used to search in the agent inventory tables.

Issues Resolved

https://github.com/wazuh/support/issues/171

Evidence

Test

UI

Test
Empty input in the search bar of the agent inventory tables should display all the results
Add a search text input in the search bar of the agent inventory tables should display filtered the results
Export to CSV each table in agents inventory with an empty search query should display all the results
Export to CSV each table in agents inventory with a search query should display results filtered
The search bar placeholder of Network ports should be Search
The search bar placeholder of Packages should be Search
The search bar placeholder of Processes ports should be Search

template_test_cases.md

Check List

All tests pass
- yarn test:jest
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

- Replace search by q API parameter

Machi3mfl

Wazuh dashboard

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test	Chrome	Firefox	Safari
Empty input in the search bar of the agent inventory tables should display all the results	🟢	⚫	⚫
Add a search text input in the search bar of the agent inventory tables should display filtered the results	🟢	⚫	⚫
Export to CSV each table in agents inventory with an empty search query should display all the results	🟢	⚫	⚫
Export to CSV each table in agents inventory with a search query should display results filtered	🟢	⚫	⚫

Details

🟢 Empty input in the search bar of the agent inventory tables should display all the results

Chrome - 🟢

Kazam_screencast_00009.mp4

Firefox - ⚫

Safari - ⚫

🟢 Add a search text input in the search bar of the agent inventory tables should display filtered the results

Chrome - 🟢

Kazam_screencast_00010.mp4

Firefox - ⚫

Safari - ⚫

🟢 Export to CSV each table in agents inventory with an empty search query should display all the results

Chrome - 🟢

Kazam_screencast_00011.mp4

Firefox - ⚫

Safari - ⚫

🟢 Export to CSV each table in agents inventory with a search query should display results filtered

Chrome - 🟢

Kazam_screencast_00011.mp4

Firefox - ⚫

Safari - ⚫

yenienserrano · 2023-02-15T10:10:01Z

Wazuh dashboard

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test	Chrome	Firefox	Safari
Empty input in the search bar of the agent inventory tables should display all the results	🟢	⚫	⚫
Add a search text input in the search bar of the agent inventory tables should display filtered the results	🟢	⚫	⚫
Export to CSV each table in agents inventory with an empty search query should display all the results	🟢	⚫	⚫
Export to CSV each table in agents inventory with a search query should display results filtered	🟢	⚫	⚫

Details

🟢 Empty input in the search bar of the agent inventory tables should display all the results

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Add a search text input in the search bar of the agent inventory tables should display filtered the results

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Export to CSV each table in agents inventory with an empty search query should display all the results

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Export to CSV each table in agents inventory with a search query should display results filtered

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

Desvelao · 2023-03-28T12:22:56Z

request changes: change the placeholder of the search bar to clarify the search is only not to a column. The search applies to all the visible columns.

… into fix/support-171-agents-inventory-search-q-parameter

Desvelao · 2023-03-28T14:16:51Z

request changes: change the placeholder of the search bar to clarify the search is only not to a column. The search applies to all the visible columns.

Changes

Replaced the search bar placeholder by Search

New tests were added:


The search bar placeholder of Network ports should be Search
The search bar placeholder of Packages should be Search
The search bar placeholder of Processes ports should be Search

Machi3mfl


The search bar placeholder of Network ports should be Search	🟢
The search bar placeholder of Packages should be Search	🟢
The search bar placeholder of Processes ports should be Search	🟢

Details

🟢 The search bar placeholder of Network ports should be Search

🟢 The search bar placeholder of Packages should be Search

🟢 The search bar placeholder of Processes ports should be Search

CHANGELOG.md

…ch-q-parameter

asteriscos

Wazuh dashboard

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test	Chrome	Firefox
Empty input in the search bar of the agent inventory tables should display all the results	🟢	⚫
Add a search text input in the search bar of the agent inventory tables should display filtered the results	🟢	⚫
Export to CSV each table in agents inventory with an empty search query should display all the results	🟢	⚫
Export to CSV each table in agents inventory with a search query should display results filtered	🟢	⚫

Details

🟢 Empty input in the search bar of the agent inventory tables should display all the results

Chrome - 🟢

Firefox - ⚫

🟢 Add a search text input in the search bar of the agent inventory tables should display filtered the results

Chrome - 🟢

Firefox - ⚫

🟢 Export to CSV each table in agents inventory with an empty search query should display all the results

Chrome - 🟢

Firefox - ⚫

🟢 Export to CSV each table in agents inventory with a search query should display results filtered

Chrome - 🟢

Firefox - ⚫

…ch-q-parameter

github-actions · 2023-03-30T20:53:42Z

Code coverage (Jest)	%	values
Statements	8.77%	( 3240 / 36925 )
Branches	4.49%	( 1287 / 28640 )
Functions	7.63%	( 698 / 9146 )
Lines	8.83%	( 3125 / 35360 )

github-actions · 2023-03-31T07:22:10Z

The backport to 4.4-7.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.16 4.4-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.16
# Create a new branch
git switch --create backport-5196-to-4.4-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4fadc4e0f6311f86b0f4adfdc0d0b00bc72337fe
# Push it to GitHub
git push --set-upstream origin backport-5196-to-4.4-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.16

Then, create a pull request where the base branch is 4.4-7.16 and the compare/head branch is backport-5196-to-4.4-7.16.

github-actions · 2023-03-31T07:22:11Z

The backport to 4.4-7.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.10 4.4-7.10
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.10
# Create a new branch
git switch --create backport-5196-to-4.4-7.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4fadc4e0f6311f86b0f4adfdc0d0b00bc72337fe
# Push it to GitHub
git push --set-upstream origin backport-5196-to-4.4-7.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.10

Then, create a pull request where the base branch is 4.4-7.10 and the compare/head branch is backport-5196-to-4.4-7.10.

* fix: change the search in the agents inventory tables - Replace search by q API parameter * changelog: add pull request entry * fix(agent-inventory): change the search bar placeholder to `Search` * fix(changelog): fix entry * fix: replace string * fix(changelog): moved entry to Fixed --------- Co-authored-by: Nicolas Agustin Guevara Pihen <42900763+Tostti@users.noreply.github.com> (cherry picked from commit 4fadc4e)

…a tables (#5346) Fix the search in the agent inventory data tables (#5196) * fix: change the search in the agents inventory tables - Replace search by q API parameter * changelog: add pull request entry * fix(agent-inventory): change the search bar placeholder to `Search` * fix(changelog): fix entry * fix: replace string * fix(changelog): moved entry to Fixed --------- Co-authored-by: Nicolas Agustin Guevara Pihen <42900763+Tostti@users.noreply.github.com> (cherry picked from commit 4fadc4e)

…a tables (#5345) Fix the search in the agent inventory data tables (#5196) * fix: change the search in the agents inventory tables - Replace search by q API parameter * changelog: add pull request entry * fix(agent-inventory): change the search bar placeholder to `Search` * fix(changelog): fix entry * fix: replace string * fix(changelog): moved entry to Fixed --------- Co-authored-by: Nicolas Agustin Guevara Pihen <42900763+Tostti@users.noreply.github.com> (cherry picked from commit 4fadc4e) Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com>

fix: change the search in the agents inventory tables

33c7944

- Replace search by q API parameter

Desvelao requested a review from a team as a code owner February 6, 2023 17:22

Desvelao self-assigned this Feb 6, 2023

changelog: add pull request entry

1b909a8

Desvelao added backport 4.4-7.16 labels Feb 6, 2023

Machi3mfl previously approved these changes Feb 6, 2023

View reviewed changes

Desvelao linked an issue Feb 7, 2023 that may be closed by this pull request

Fix the search in the agents inventory table #5198

Closed

Desvelao mentioned this pull request Feb 7, 2023

Fix the search in the agents inventory table #5198

Closed

yenienserrano previously approved these changes Feb 15, 2023

View reviewed changes

Desvelao mentioned this pull request Feb 27, 2023

New search bar component #4312

Closed

6 tasks

fix(agent-inventory): change the search bar placeholder to Search

a142fd0

Desvelao dismissed stale reviews from yenienserrano and Machi3mfl via a142fd0 March 28, 2023 14:06

Desvelao added 3 commits March 28, 2023 16:11

Merge branch '4.4-2.4-wzd' of https://github.com/wazuh/wazuh-kibana-app…

f46b2ad

… into fix/support-171-agents-inventory-search-q-parameter

fix(changelog): fix entry

46e0273

fix: replace string

22024ea

Desvelao requested review from Machi3mfl and yenienserrano March 28, 2023 14:24

Machi3mfl previously approved these changes Mar 28, 2023

View reviewed changes

AlexRuiz7 suggested changes Mar 29, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

fix(changelog): moved entry to Fixed

4f8d376

Desvelao dismissed Machi3mfl’s stale review via 4f8d376 March 30, 2023 06:35

Desvelao requested a review from AlexRuiz7 March 30, 2023 06:35

Desvelao changed the title ~~Change the search in the agents inventory tables~~ Fix the search in the agent inventory data tables Mar 30, 2023

AlexRuiz7 previously approved these changes Mar 30, 2023

View reviewed changes

Merge branch '4.4-2.4-wzd' into fix/support-171-agents-inventory-sear…

faf7dcd

…ch-q-parameter

Desvelao dismissed AlexRuiz7’s stale review via faf7dcd March 30, 2023 14:14

Machi3mfl previously approved these changes Mar 30, 2023

View reviewed changes

AlexRuiz7 previously approved these changes Mar 30, 2023

View reviewed changes

asteriscos previously approved these changes Mar 30, 2023

View reviewed changes

Merge branch '4.4-2.4-wzd' into fix/support-171-agents-inventory-sear…

7f0ac99

…ch-q-parameter

Tostti dismissed stale reviews from asteriscos, AlexRuiz7, and Machi3mfl via 7f0ac99 March 30, 2023 20:49

yenienserrano approved these changes Mar 31, 2023

View reviewed changes

yenienserrano merged commit 4fadc4e into 4.4-2.4-wzd Mar 31, 2023
3 checks passed

yenienserrano deleted the fix/support-171-agents-inventory-search-q-parameter branch March 31, 2023 07:21

yenienserrano mentioned this pull request Mar 31, 2023

[Backport 5196 to 4.4 7.16] Fix the search in the agent inventory data tables #5345

Merged

Desvelao mentioned this pull request Mar 31, 2023

[Backport 5196 to 4.4-7.10] Fix the search in the agent inventory data tables #5346

Merged

Desvelao mentioned this pull request Apr 5, 2023

Release 4.4.1 - RC1 - Kibana UI regression testing #5356

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the search in the agent inventory data tables #5196

Fix the search in the agent inventory data tables #5196

Desvelao commented Feb 6, 2023 •

edited

Machi3mfl left a comment

yenienserrano commented Feb 15, 2023 •

edited

Desvelao commented Mar 28, 2023 •

edited

Desvelao commented Mar 28, 2023 •

edited

Machi3mfl left a comment

asteriscos left a comment •

edited

github-actions bot commented Mar 30, 2023

github-actions bot commented Mar 31, 2023

github-actions bot commented Mar 31, 2023

Fix the search in the agent inventory data tables #5196

Fix the search in the agent inventory data tables #5196

Conversation

Desvelao commented Feb 6, 2023 • edited

Description

Issues Resolved

Evidence

Test

Check List

Machi3mfl left a comment

Choose a reason for hiding this comment

Wazuh dashboard

UI

yenienserrano commented Feb 15, 2023 • edited

Wazuh dashboard

UI

Desvelao commented Mar 28, 2023 • edited

Desvelao commented Mar 28, 2023 • edited

Changes

Machi3mfl left a comment

Choose a reason for hiding this comment

asteriscos left a comment • edited

Choose a reason for hiding this comment

Wazuh dashboard

UI

github-actions bot commented Mar 30, 2023

github-actions bot commented Mar 31, 2023

github-actions bot commented Mar 31, 2023

Desvelao commented Feb 6, 2023 •

edited

yenienserrano commented Feb 15, 2023 •

edited

Desvelao commented Mar 28, 2023 •

edited

Desvelao commented Mar 28, 2023 •

edited

asteriscos left a comment •

edited