Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 5196 to 4.4 7.16] Fix the search in the agent inventory data tables #5345

Merged
merged 2 commits into from
Mar 31, 2023
Merged

[Backport 5196 to 4.4 7.16] Fix the search in the agent inventory data tables #5345

merged 2 commits into from
Mar 31, 2023

Conversation

yenienserrano
Copy link
Member

Backport 4fadc4e from #5196.

@Desvelao @yenienserrano
Fix the search in the agent inventory data tables (#5196)
119ed16 
* fix: change the search in the agents inventory tables

- Replace search by q API parameter

* changelog: add pull request entry

* fix(agent-inventory): change the search bar placeholder to `Search`

* fix(changelog): fix entry

* fix: replace string

* fix(changelog): moved entry to Fixed

---------

Co-authored-by: Nicolas Agustin Guevara Pihen <42900763+Tostti@users.noreply.github.com>
(cherry picked from commit 4fadc4e)
@yenienserrano yenienserrano requested a review from a team as a code owner March 31, 2023 07:28
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.6% ( 3257 / 37853 )
Branches 4.4% ( 1287 / 29232 )
Functions 7.48% ( 703 / 9400 )
Lines 8.68% ( 3142 / 36203 )

@yenienserrano yenienserrano linked an issue Mar 31, 2023 that may be closed by this pull request
Fix the search in the agents inventory table #5198
Closed
@Desvelao
Copy link
Member

Desvelao commented Mar 31, 2023 •
edited

Kibana 7.17.6

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
Empty input in the search bar of the agent inventory tables should display all the results 🟢 ⚫ ⚫
Add a search text input in the search bar of the agent inventory tables should display filtered the results ⚫ ⚫ ⚫
Export to CSV each table in agents inventory with an empty search query should display all the results 🟢 ⚫ ⚫
Export to CSV each table in agents inventory with a search query should display results filtered 🟢 ⚫ ⚫

Details

🟢 Empty input in the search bar of the agent inventory tables should display all the results

Chrome - 🟢
image

Firefox - ⚫

Safari - ⚫

🟢 Add a search text input in the search bar of the agent inventory tables should display filtered the results

Chrome - 🟢
image

Firefox - ⚫

Safari - ⚫

🟢 Export to CSV each table in agents inventory with an empty search query should display all the results

Chrome - ⚫
image

Firefox - ⚫

Safari - ⚫

🟢 Export to CSV each table in agents inventory with a search query should display results filtered

Chrome - 🟢
image

Firefox - ⚫

Safari - ⚫

Desvelao
Desvelao approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

🟢 code
🟢 test #5345 (comment)

@Desvelao Desvelao merged commit 87c9668 into 4.4-7.16 Mar 31, 2023
@Desvelao Desvelao deleted the backport-5196-to-4.4-7.16 branch March 31, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the search in the agents inventory table
2 participants
@yenienserrano @Desvelao