Added ErrorBoundary HOC and component. #3321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loglevel dependency
gabiwassan
requested review from
Machi3mfl and
a team
and removed request for
Machi3mfl
Desvelao
reviewed
Jun 1, 2021
public/components/common/hocs/error-boundary/with-error-boundary.tsx
Outdated
Show resolved
Hide resolved
|
I suggest exporting the HOC in the |
frankeros
reviewed
Jun 2, 2021
public/components/common/hocs/error-boundary/with-error-boundary.tsx
Outdated
Show resolved
Hide resolved
|
please add unit test for the new components |
Desvelao
reviewed
Jun 4, 2021
public/components/common/hocs/error-boundary/with-error-boundary.tsx
Outdated
Show resolved
Hide resolved
|
As a suggestion, you could add the license block to the new files (not to snapshots). |
gabiwassan
added a commit
that referenced
this pull request
Jun 14, 2021
* Feature/3316 error handler orchestrator (#3327) * feat(errorBoundary): Added ErrorBoundary HOC and component and added loglevel dependency * feature(errorBoundary): Moved with the others HOCs. * feature(errorBoundary): Typo refactor. * First attempt LoggerService * Merged error boundary, integrated loggerService. * changed logger name, create logger-service test file * Updated CHANGELOG * Moved to react-services, changed name, traslates comments * feat(errorBoundary): Removed old integration * refactor(loggerService): Changed class for function methods. * test(logger-service): Added basic unit test to logger-service * refactor(logger-service): Applied new implementation of error-orchestrator service. * feature(logger-service): PR comments and some refactors. Co-authored-by: gabiwassan <gabriel.wassan@wazuh.com> Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com> * Added ErrorBoundary HOC and component. (#3321) * feat(errorBoundary): Added ErrorBoundary HOC and component and added loglevel dependency * feature(errorBoundary): Moved with the others HOCs. * feature(errorBoundary): Typo refactor. * feature(errorBoundary): Some refactors * feat(errorBoundary): PR comments and rollback agent-preview * doc(changelog): Update changelog * feat(errorBoundary): Rollback * feat(errorBoundary): Rollback * feat(errorBoundary): Rollback * feat(errorBoundary): Rollback * feat(errorBoundary): Refactor props, pr comments. * feat(errorBoundary): Added unit test for error boundary. * feat(errorBoundary): Separated error boundary component of hoc * doc(error-boundary): Fixed and added licenses blocks. * feature(logger-service): PR comments * feature(logger-orchestrator): Refactors on management of severity. * feature(logger-orchestrator): Refactor on wz-blank-screen component. * feature(logger-orchestrator): Separated prompt component from error-boundary. * feature(logger-orchestrator): Typo. * test(error-boundary): Update snapshots. * test(error-boundary): Update snapshots * fix(logger-orchestrator): PR comments and refactors, fix unit tests. * test(error-orchestrator-base): Added simple unit test. Fixed licence block. * test(error-orchestrator-base): Added simple unit test to ErrorOrchestratorCritical * test(error-orchestrator-ui): Added simple unit test to ErrorOrchestratorUi * Create new backend service (#3324) * Add endpoint * Create new backend service * Add changelog * Renamed constants * Added interfaces, created new controller and renamed * Created ui-logged, to prevent logger superclass * Added types, fixed responses types * Added new route file to ui-logs, changed method put to post, added in index,ts * Added test files, we must create all unit tests to those new features * Fixed if condition * Rename tests files, created endpoints test * Changed controller name ui-logs, removed duplicated export * Fixed file comments * Applied prettier formater * Added new base class base-logger * Remove wrong constants and fix errors * test(ui-logger-controller): Added simple unit test. * test(ui-logs-controller): Fix params. * Added test to ui-logs controller * Renamed test files * test(logs-controller): Added mock to function checkFileExist + prettier. * Solve comments * Add copyright and remove unused import Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com> Co-authored-by: gabiwassan <gabriel.wassan@wazuh.com> * bugfix(error-orchestrator): Added some improvements and fixes. * test(ui-logs-controller): Updated unit test. * fix(error-orchestrator): PR comments * fix(error-orchestrator): PR comments + prettier. Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com> Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com> Co-authored-by: Pablo Martínez <pablo.martinez@wazuh.com>
gabiwassan
added a commit
that referenced
this pull request
Jun 15, 2021
* Feature/3316 error handler orchestrator (#3327) * feat(errorBoundary): Added ErrorBoundary HOC and component and added loglevel dependency * feature(errorBoundary): Moved with the others HOCs. * feature(errorBoundary): Typo refactor. * First attempt LoggerService * Merged error boundary, integrated loggerService. * changed logger name, create logger-service test file * Updated CHANGELOG * Moved to react-services, changed name, traslates comments * feat(errorBoundary): Removed old integration * refactor(loggerService): Changed class for function methods. * test(logger-service): Added basic unit test to logger-service * refactor(logger-service): Applied new implementation of error-orchestrator service. * feature(logger-service): PR comments and some refactors. Co-authored-by: gabiwassan <gabriel.wassan@wazuh.com> Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com> * Added ErrorBoundary HOC and component. (#3321) * feat(errorBoundary): Added ErrorBoundary HOC and component and added loglevel dependency * feature(errorBoundary): Moved with the others HOCs. * feature(errorBoundary): Typo refactor. * feature(errorBoundary): Some refactors * feat(errorBoundary): PR comments and rollback agent-preview * doc(changelog): Update changelog * feat(errorBoundary): Rollback * feat(errorBoundary): Rollback * feat(errorBoundary): Rollback * feat(errorBoundary): Rollback * feat(errorBoundary): Refactor props, pr comments. * feat(errorBoundary): Added unit test for error boundary. * feat(errorBoundary): Separated error boundary component of hoc * doc(error-boundary): Fixed and added licenses blocks. * feature(logger-service): PR comments * feature(logger-orchestrator): Refactors on management of severity. * feature(logger-orchestrator): Refactor on wz-blank-screen component. * feature(logger-orchestrator): Separated prompt component from error-boundary. * feature(logger-orchestrator): Typo. * test(error-boundary): Update snapshots. * test(error-boundary): Update snapshots * fix(logger-orchestrator): PR comments and refactors, fix unit tests. * test(error-orchestrator-base): Added simple unit test. Fixed licence block. * test(error-orchestrator-base): Added simple unit test to ErrorOrchestratorCritical * test(error-orchestrator-ui): Added simple unit test to ErrorOrchestratorUi * Create new backend service (#3324) * Add endpoint * Create new backend service * Add changelog * Renamed constants * Added interfaces, created new controller and renamed * Created ui-logged, to prevent logger superclass * Added types, fixed responses types * Added new route file to ui-logs, changed method put to post, added in index,ts * Added test files, we must create all unit tests to those new features * Fixed if condition * Rename tests files, created endpoints test * Changed controller name ui-logs, removed duplicated export * Fixed file comments * Applied prettier formater * Added new base class base-logger * Remove wrong constants and fix errors * test(ui-logger-controller): Added simple unit test. * test(ui-logs-controller): Fix params. * Added test to ui-logs controller * Renamed test files * test(logs-controller): Added mock to function checkFileExist + prettier. * Solve comments * Add copyright and remove unused import Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com> Co-authored-by: gabiwassan <gabriel.wassan@wazuh.com> * bugfix(error-orchestrator): Added some improvements and fixes. * test(ui-logs-controller): Updated unit test. * Settings * Added hoc * Before rebase * rebase 4.3-7.10 * Feature/3316 error handler orchestrator (#3327) * feat(errorBoundary): Added ErrorBoundary HOC and component and added loglevel dependency * feature(errorBoundary): Moved with the others HOCs. * feature(errorBoundary): Typo refactor. * First attempt LoggerService * Merged error boundary, integrated loggerService. * changed logger name, create logger-service test file * Updated CHANGELOG * Moved to react-services, changed name, traslates comments * feat(errorBoundary): Removed old integration * refactor(loggerService): Changed class for function methods. * test(logger-service): Added basic unit test to logger-service * refactor(logger-service): Applied new implementation of error-orchestrator service. * feature(logger-service): PR comments and some refactors. Co-authored-by: gabiwassan <gabriel.wassan@wazuh.com> Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com> * Final implementations * Fix errors and apply prettier * Added changelog Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com> Co-authored-by: gabiwassan <gabriel.wassan@wazuh.com> Co-authored-by: Ibarra Maximiliano <maximiliano.ibarra@wazuh.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
This PR includes the implementation of the ErrorBoundary component and HOC to catch components with errors on rendering.
Plus added
logleveldependency to log errors, warnings, etc.e.g of error prompt:
Closes: #3313