Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Office365 sample data #3424

Merged
merged 6 commits into from
Jul 23, 2021

Conversation

sortiz1191
Copy link
Contributor

Hi team!
This PR adds sample data for Office 365
Issue #3401

@sortiz1191 sortiz1191 self-assigned this Jul 1, 2021
@sortiz1191 sortiz1191 changed the base branch from 4.3-7.10 to feature/3371_office365-section July 1, 2021 12:23
@sortiz1191 sortiz1191 changed the title Feature/3401 office365 sample data Office365 sample data Jul 1, 2021
@sortiz1191 sortiz1191 changed the title Office365 sample data Added Office365 sample data Jul 1, 2021
Comment on lines 344 to 354
ExtendedProperties: Office.arrayExtendedPropertiesOffice,
ModifiedProperties: [],
Actor: Office.arrayActorOffice,
ActorContextId: OrgID,
ActorIpAddress: "77.231.182.17",
InterSystemsId: InterID,
IntraSystemId: IntraID,
Target: Office.arrayTargetOffice,
TargetContextId: OrgID,
ApplicationId: appID,
DeviceProperties: Office.arrayDevicePropertiesOffice,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: There are multiple values that are arrays. Maybe you want to select one of them instead of all the array?

suggestion: Select one value. You could use randomArrayItem function to do this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the example JSON file, there are some array values with some objects for each array.
This should be an objects array by default like:

"DeviceProperties": [{ "Name": "BrowserType", "Value": "Chrome" }, { "Name": "IsCompliantAndManaged", "Value": "False" }, { "Name": "SessionId", "Value": "2a1fb8c4-ceb6-4fa0-826c-3d43f87de897" }],

Comment on lines 1 to 16
/*
* Wazuh app - Amazon Web Services interactive extension guide
* Copyright (C) 2015-2021 Wazuh, Inc.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* Find more information about this on the LICENSE file.
*/
export default {
id: 'office',
name: 'Office 365',
wodle_name: 'office',
description: 'Configuration options of the Office 365 wodle.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment: This file is used for a not-released feature. At the moment, maybe this could not be necessary. But I guess, there is not a problem if we add to the source code.

@sortiz1191
Copy link
Contributor Author

@Desvelao
All removed lines are from the module navigation. This code has been moved to the branch #3420

server/lib/generate-alerts/generate-alerts-script.js Outdated Show resolved Hide resolved
server/lib/generate-alerts/generate-alerts-script.js Outdated Show resolved Hide resolved
server/lib/generate-alerts/sample-data/office.js Outdated Show resolved Hide resolved
@mpRegalado mpRegalado force-pushed the feature/3401_office365_sample-data branch from a4a40d5 to 4ee5ef9 Compare July 9, 2021 13:51
@sortiz1191 sortiz1191 changed the base branch from feature/3371_office365-section to feature/Office365 July 9, 2021 13:52
@sortiz1191 sortiz1191 marked this pull request as draft July 9, 2021 13:53
Using all the logs provided by core and randomized sample data on new fields.
@mpRegalado mpRegalado marked this pull request as ready for review July 23, 2021 08:16
@mpRegalado mpRegalado dismissed their stale review July 23, 2021 08:19

I made it and applied the changes myself.

Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would fix some minor changes

public/components/add-modules-data/guides/office.js Outdated Show resolved Hide resolved
server/lib/generate-alerts/sample-data/office.js Outdated Show resolved Hide resolved
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review:
Code Review ✅

@Desvelao Desvelao merged commit 563e4b1 into feature/Office365 Jul 23, 2021
@Desvelao Desvelao deleted the feature/3401_office365_sample-data branch July 23, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants