-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Office365 sample data #3424
Added Office365 sample data #3424
Conversation
ExtendedProperties: Office.arrayExtendedPropertiesOffice, | ||
ModifiedProperties: [], | ||
Actor: Office.arrayActorOffice, | ||
ActorContextId: OrgID, | ||
ActorIpAddress: "77.231.182.17", | ||
InterSystemsId: InterID, | ||
IntraSystemId: IntraID, | ||
Target: Office.arrayTargetOffice, | ||
TargetContextId: OrgID, | ||
ApplicationId: appID, | ||
DeviceProperties: Office.arrayDevicePropertiesOffice, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: There are multiple values that are arrays. Maybe you want to select one of them instead of all the array?
suggestion: Select one value. You could use randomArrayItem
function to do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the example JSON file, there are some array values with some objects for each array.
This should be an objects array by default like:
"DeviceProperties": [{ "Name": "BrowserType", "Value": "Chrome" }, { "Name": "IsCompliantAndManaged", "Value": "False" }, { "Name": "SessionId", "Value": "2a1fb8c4-ceb6-4fa0-826c-3d43f87de897" }],
/* | ||
* Wazuh app - Amazon Web Services interactive extension guide | ||
* Copyright (C) 2015-2021 Wazuh, Inc. | ||
* | ||
* This program is free software; you can redistribute it and/or modify | ||
* it under the terms of the GNU General Public License as published by | ||
* the Free Software Foundation; either version 2 of the License, or | ||
* (at your option) any later version. | ||
* | ||
* Find more information about this on the LICENSE file. | ||
*/ | ||
export default { | ||
id: 'office', | ||
name: 'Office 365', | ||
wodle_name: 'office', | ||
description: 'Configuration options of the Office 365 wodle.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment: This file is used for a not-released feature. At the moment, maybe this could not be necessary. But I guess, there is not a problem if we add to the source code.
a4a40d5
to
4ee5ef9
Compare
Using all the logs provided by core and randomized sample data on new fields.
I made it and applied the changes myself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would fix some minor changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review:
Code Review ✅
Hi team!
This PR adds sample data for Office 365
Issue #3401