-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement try catch strategy in common/modules and management/groups #3465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Machi3mfl
reviewed
Jul 14, 2021
public/components/management/groups/multiple-agent-selector.tsx
Outdated
Show resolved
Hide resolved
public/components/management/groups/multiple-agent-selector.tsx
Outdated
Show resolved
Hide resolved
public/components/management/groups/multiple-agent-selector.tsx
Outdated
Show resolved
Hide resolved
public/components/management/groups/multiple-agent-selector.tsx
Outdated
Show resolved
Hide resolved
public/components/management/groups/multiple-agent-selector.tsx
Outdated
Show resolved
Hide resolved
Machi3mfl
approved these changes
Jul 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
gabiwassan
approved these changes
Jul 15, 2021
|
gabiwassan
added a commit
that referenced
this pull request
Jul 30, 2021
…3465) * Implement try catch strategy * Replace throw * Fix changelog * Fix errors * Remove store * doc(changelog): Update Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com> Co-authored-by: gabiwassan <gabriel.wassan@wazuh.com>
gabiwassan
added a commit
that referenced
this pull request
Aug 5, 2021
…3465) * Implement try catch strategy * Replace throw * Fix changelog * Fix errors * Remove store * doc(changelog): Update Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com> Co-authored-by: gabiwassan <gabriel.wassan@wazuh.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
This PR implements a new strategy to catch and store/show errors in common/modules and management/groups.
Close #3464