Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement try catch strategy in common/modules and management/groups #3465

Merged
merged 9 commits into from
Jul 20, 2021

Conversation

pablomarga
Copy link
Contributor

Hi team,
This PR implements a new strategy to catch and store/show errors in common/modules and management/groups.

Close #3464

@pablomarga pablomarga requested a review from a team July 13, 2021 11:56
@pablomarga pablomarga self-assigned this Jul 13, 2021
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gabiwassan gabiwassan merged commit 63bb06d into 4.3-7.10 Jul 20, 2021
@gabiwassan gabiwassan deleted the implement/try-catch-modules branch July 20, 2021 18:52
@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 3.62% ( 1281 / 35390 )
Branches 1.44% ( 401 / 27907 )
Functions 2.5% ( 214 / 8571 )
Lines 3.65% ( 1236 / 33832 )

gabiwassan added a commit that referenced this pull request Jul 30, 2021
…3465)

* Implement try catch strategy

* Replace throw

* Fix changelog

* Fix errors

* Remove store

* doc(changelog): Update

Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com>
Co-authored-by: gabiwassan <gabriel.wassan@wazuh.com>
gabiwassan added a commit that referenced this pull request Aug 5, 2021
…3465)

* Implement try catch strategy

* Replace throw

* Fix changelog

* Fix errors

* Remove store

* doc(changelog): Update

Co-authored-by: Maximiliano Ibarra <maximilianoaibarra@gmail.com>
Co-authored-by: gabiwassan <gabriel.wassan@wazuh.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants