Github/Office365 multi-select filters fix to get suggested values #3787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nitpick: The PR should be integrated with apps for Kibana 7.10.2 until 7.16.x, so we should change the base branch of PR to point to the development branch for the app of Kibana 7.10.2. |
Desvelao
reviewed
Jan 7, 2022
| @@ -69,7 +69,7 @@ export const useValueSuggestion = ( | |||
| : await data.autocomplete.getValueSuggestions({ | |||
| query, | |||
| indexPattern: indexPattern as IIndexPattern, | |||
| field, | |||
| field: { ...field, toSpec: (options) => field }, | |||
There was a problem hiding this comment.
question: Is this change required to work? I am not sure if only another change of this PR, solves the problem.
|
review PR requirements:
|
Desvelao
deleted the
fix/github-multi-select-filters-fail-to-get-suggested-values-3779
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
this PR fixes multi-select filters failing to get suggested values due to the index pattern not having attribute.fields property.
Closes #3779
To test it: