Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored events documents discover links building #3866

Merged
merged 3 commits into from
Mar 2, 2022

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Mar 1, 2022

Hi team,

this PR refactors events documents links to avoid using a resolver with internal re-directions. This allows to disable the overview plugin, as it doesn't rely on that plugin to make re-directions.

Closes #3850

To test it:

  • Go to Security Events -> Events
  • Click on a document row to open it
  • Check View surrounding documents & View single document links are pointing to Discover plugin (not Wazuh)
  • Check View surrounding documents & View single document are loading properly

image

  • Click on a field under Selected fields section
  • Check Visualize button is loading properly
    image

@asteriscos asteriscos added the 4.3 label Mar 1, 2022
@asteriscos asteriscos requested a review from Desvelao March 1, 2022 16:34
@asteriscos asteriscos self-assigned this Mar 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2022

Jest Test Coverage % values
Statements 4.04% ( 1474 / 36460 )
Branches 1.61% ( 459 / 28444 )
Functions 2.97% ( 264 / 8901 )
Lines 4.09% ( 1426 / 34856 )

Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review
Test ✅

Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✅

@Desvelao Desvelao merged commit 946196f into 4.3-7.10 Mar 2, 2022
@Desvelao Desvelao deleted the fix/events-documents-routes-resolvers-3850 branch March 2, 2022 10:47
Desvelao pushed a commit that referenced this pull request Mar 2, 2022
* Refactored events discover links building

* fixed base url building

* Added changelog
@Desvelao Desvelao linked an issue Mar 4, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Events documents are redirecting to the homepage - OpenSearch
3 participants