Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change google group icon #3949

Merged
merged 3 commits into from
Apr 6, 2022
Merged

Conversation

asteriscos
Copy link
Member

Hi team,

this PR replaces old Google Group Icon by the new one.

Closes #3943

image

image

@asteriscos asteriscos self-assigned this Apr 5, 2022
@asteriscos asteriscos linked an issue Apr 5, 2022 that may be closed by this pull request
@asteriscos asteriscos added the 4.3 label Apr 5, 2022
@yenienserrano
Copy link
Member

starting the project with --no-base-path the icons are seen but if we start it without the --no-base-path the icon is not seen

…ut` section when Kibana is served in a subpath
@Desvelao
Copy link
Member

Desvelao commented Apr 6, 2022

starting the project with --no-base-path the icons are seen but if we start it without the --no-base-path the icon is not seen

Good catch!

Fixed in cf4d7c9.

@Desvelao Desvelao merged commit 28f64a1 into 4.3-7.10 Apr 6, 2022
@Desvelao Desvelao deleted the enhance/change-google-group-icon-3943 branch April 6, 2022 07:12
@Desvelao Desvelao mentioned this pull request Apr 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

Jest Test Coverage % values
Statements 4.04% ( 1476 / 36559 )
Branches 1.61% ( 459 / 28480 )
Functions 2.98% ( 266 / 8934 )
Lines 4.09% ( 1428 / 34951 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add icon "Google group"
3 participants