Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve messages in the agent installation #4040

Merged
merged 7 commits into from
Apr 28, 2022

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Apr 19, 2022

Description:

Changes were made to the messages in the agent installation guide.

  • From You can predefine the Wazuh server address with the enrollment.dns setting to This is the address the agent uses to communicate with the Wazuh server. It can be an IP address or a fully qualified domain name (FQDN).

  • From Running this command on a host with an agent already installed upgrades the agent package without enrolling the agent. To enroll it, see the Wazuh documentation to If the installer finds another Wazuh agent in the system, it will upgrade it preserving the configuration.

Test:

  1. Navigate to Agents
  2. Click on Deploy a new agent
  3. Look at the changes

Issues:

Improve messages on agent installation walkthrough #4037
Improve messages in the agent installation instructions #4036

Screenshot:
image
image

Copy link
Member

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yenienserrano yenienserrano added 4.3 and removed 4.3 labels Apr 19, 2022
@yenienserrano
Copy link
Member Author

Updated proposal
image

@yenienserrano
Copy link
Member Author

Updated proposal
image

@Mayons
Copy link

Mayons commented Apr 26, 2022

Testing in progress, waiting for a response of #4036 from @yenienserrano

@Mayons Mayons self-requested a review April 26, 2022 18:15
@yenienserrano
Copy link
Member Author

@Desvelao Desvelao merged commit a57be82 into 4.3-7.10 Apr 28, 2022
@Desvelao Desvelao deleted the improve-messages-in-the-agent-installation branch April 28, 2022 06:32
@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 4.04% ( 1474 / 36526 )
Branches 1.61% ( 459 / 28465 )
Functions 2.98% ( 266 / 8929 )
Lines 4.08% ( 1426 / 34921 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve messages on agent installation walkthrough Improve messages in the agent installation instructions
4 participants