Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Initialize] Remove the migrations tasks related to deprecated .wazuh indices (.wazuh and .wazuh-version) #4098

Merged

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Apr 25, 2022

Description

This PR removes the migration tasks in the deprecated .wazuh indices (.wazuh and .wazuh-version). Moreover, an additional side-effect of these changes is the some logs related to these indices won't appear in the plugin logs.

For example, the error in the plugin:

ERROR  Could not check if the index .wazuh exists due to no permissions for create, delete or check

could be interpreted as an error while this could be ignored for new installations.

Changes

  • Removed the migration tasks in the .wazuh indices ( .wazuh and .wazuh-version).

Test

  • With an environment with the internal user with no permisions in the .wazuh index, the above log should not appear.
  • The wazuh-registry.json file should be created in new environments if it doesn't exist when the plugin starts ( located in <PLUGIN_PLATFORM_PATH>/data/wazuh/config/wazuh-registry.json)

Closes #3941

… deprecated wazuh indices (.wazuh and .wazuh-version)

  - Note this change avoids the appearance of logs related to indices when the internal user has no permissions on them.
@Desvelao Desvelao self-assigned this Apr 25, 2022
@Desvelao Desvelao changed the title [Initialize] Remove the migrations tasks related to deprecated wazuh indices (.wazuh and .wazuh-version) [Initialize] Remove the migrations tasks related to deprecated wazuh indices (.wazuh and .wazuh-version) Apr 25, 2022
@Desvelao Desvelao added the type/enhancement Enhancement issue label Apr 25, 2022
@Desvelao Desvelao changed the title [Initialize] Remove the migrations tasks related to deprecated wazuh indices (.wazuh and .wazuh-version) [Initialize] Remove the migrations tasks related to deprecated .wazuh indices (.wazuh and .wazuh-version) Apr 25, 2022
@Desvelao Desvelao linked an issue Apr 25, 2022 that may be closed by this pull request
Copy link
Member

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: passed
Test: passed

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test: ✔️
CR: ✔️

@Desvelao Desvelao merged commit 208d801 into 4.3-7.10 Apr 27, 2022
@Desvelao Desvelao deleted the feat/3941-remove-logic-related-deprecated-wazuh-indices branch April 27, 2022 14:49
@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 4.04% ( 1474 / 36520 )
Branches 1.61% ( 459 / 28457 )
Functions 2.98% ( 266 / 8929 )
Lines 4.08% ( 1426 / 34915 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Enhancement issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error log on a successful installation
4 participants