Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed unhandled error throw #4188

Merged
merged 3 commits into from
Jun 2, 2022
Merged

Fixed unhandled error throw #4188

merged 3 commits into from
Jun 2, 2022

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Jun 2, 2022 •
edited
Loading

Description

This PR fixes an unhandled error throw and lets the error orchestrator handle it.

Closes #4189

@asteriscos asteriscos added the 4.3 label Jun 2, 2022
@asteriscos asteriscos self-assigned this Jun 2, 2022
@asteriscos asteriscos linked an issue Jun 2, 2022 that may be closed by this pull request
[BUG] Remove possible unhandled promise in the Agents section when fetching data related to agents statuses #4189
Closed
Desvelao
Desvelao approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review
code review ✔️

@Desvelao Desvelao added the type/bug Bug issue label Jun 2, 2022
@asteriscos asteriscos added backport 4.3-7.16 and removed type/bug Bug issue labels Jun 2, 2022
@asteriscos asteriscos merged commit 05013f5 into 4.3-7.10 Jun 2, 2022
@asteriscos asteriscos deleted the fix/removed-unhandled-error-throw branch June 2, 2022 14:38
github-actions bot pushed a commit that referenced this pull request Jun 2, 2022
@asteriscos @github-actions
Fixed unhandled error throw (#4188)
a7de8cc 
* Fixed unhandled error throw

* Added changelog

* Fixed changelog

(cherry picked from commit 05013f5)
@github-actions github-actions bot mentioned this pull request Jun 2, 2022
Merged
github-actions bot pushed a commit that referenced this pull request Jun 2, 2022
@asteriscos @github-actions
Fixed unhandled error throw (#4188)
aea55ea 
* Fixed unhandled error throw

* Added changelog

* Fixed changelog

(cherry picked from commit 05013f5)
@github-actions github-actions bot mentioned this pull request Jun 2, 2022
Merged
github-actions bot pushed a commit that referenced this pull request Jun 2, 2022
@asteriscos @github-actions
Fixed unhandled error throw (#4188)
d124a8f 
* Fixed unhandled error throw

* Added changelog

* Fixed changelog

(cherry picked from commit 05013f5)
@github-actions github-actions bot mentioned this pull request Jun 2, 2022
Merged
github-actions bot pushed a commit that referenced this pull request Jun 2, 2022
@asteriscos @github-actions
Fixed unhandled error throw (#4188)
6f0b671 
* Fixed unhandled error throw

* Added changelog

* Fixed changelog

(cherry picked from commit 05013f5)
@github-actions github-actions bot mentioned this pull request Jun 2, 2022
Merged
asteriscos added a commit that referenced this pull request Jun 2, 2022
@github-actions @asteriscos
[Backport 4.3-7.16] Fixed unhandled error throw (#4190)
f15d112 
Fixed unhandled error throw (#4188)

* Fixed unhandled error throw

* Added changelog

* Fixed changelog

(cherry picked from commit 05013f5)

Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
asteriscos added a commit that referenced this pull request Jun 2, 2022
@github-actions @asteriscos
[Backport 4.3-1.2-wzd] Fixed unhandled error throw (#4191)
c2b2571 
Fixed unhandled error throw (#4188)

* Fixed unhandled error throw

* Added changelog

* Fixed changelog

(cherry picked from commit 05013f5)

Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
asteriscos added a commit that referenced this pull request Jun 2, 2022
@github-actions @asteriscos
[Backport cloud/4.3-7.10] Fixed unhandled error throw (#4192)
f7fa01d 
Fixed unhandled error throw (#4188)

* Fixed unhandled error throw

* Added changelog

* Fixed changelog

(cherry picked from commit 05013f5)

Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
asteriscos added a commit that referenced this pull request Jun 2, 2022
@github-actions @asteriscos
[Backport cloud/4.3-7.10-custom-agents-view] Fixed unhandled error th…
8e41f06 
…row (#4193)

Fixed unhandled error throw (#4188)

* Fixed unhandled error throw

* Added changelog

* Fixed changelog

(cherry picked from commit 05013f5)

Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

Jest Test Coverage % values
Statements 4.09% ( 1489 / 36380 )
Branches 1.68% ( 473 / 28238 )
Functions 3.06% ( 272 / 8897 )
Lines 4.14% ( 1440 / 34798 )

@gdiazlo gdiazlo mentioned this pull request Jun 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Remove possible unhandled promise in the Agents section when fetching data related to agents statuses
2 participants
@asteriscos @Desvelao