-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed errors in group reports #4350
Conversation
…operty of undefined - Fixed an error due to accessing to a property of undefined when the API request to get the group configuration failed due to token expiration or another error. - Changed styles of `Agents in groups` title - Fixed a problem with missing agents in the table for a group report. Now it gets all the agents. - Removed unnecessary API request - Optimized API requests to get the agent information required to print the agents in group's table - Removed `manager_host` deprecated field: - Removed of monitoring template mapping - Removed field meaning - Removed displaying its value reports if the field `manager` doesn't exist
36907b9
to
5554910
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* fix(reports): error generating group reports due to accessing to a property of undefined - Fixed an error due to accessing to a property of undefined when the API request to get the group configuration failed due to token expiration or another error. - Changed styles of `Agents in groups` title - Fixed a problem with missing agents in the table for a group report. Now it gets all the agents. - Removed unnecessary API request - Optimized API requests to get the agent information required to print the agents in group's table - Removed `manager_host` deprecated field: - Removed of monitoring template mapping - Removed field meaning - Removed displaying its value reports if the field `manager` doesn't exist * changelog: add PR entry * fix(reporting): replaced parameter type * fix(reporting): replaced message when there are no agent in group Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 8ffce0e)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.3-1.2-wzd 4.3-1.2-wzd
# Navigate to the new working tree
cd .worktrees/backport-4.3-1.2-wzd
# Create a new branch
git switch --create backport-4350-to-4.3-1.2-wzd
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8ffce0ea89f6ba534cfb20f6a26301d264a528fb
# Push it to GitHub
git push --set-upstream origin backport-4350-to-4.3-1.2-wzd
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.3-1.2-wzd Then, create a pull request where the |
Fixed errors in group reports (#4350) * fix(reports): error generating group reports due to accessing to a property of undefined - Fixed an error due to accessing to a property of undefined when the API request to get the group configuration failed due to token expiration or another error. - Changed styles of `Agents in groups` title - Fixed a problem with missing agents in the table for a group report. Now it gets all the agents. - Removed unnecessary API request - Optimized API requests to get the agent information required to print the agents in group's table - Removed `manager_host` deprecated field: - Removed of monitoring template mapping - Removed field meaning - Removed displaying its value reports if the field `manager` doesn't exist * changelog: add PR entry * fix(reporting): replaced parameter type * fix(reporting): replaced message when there are no agent in group Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 8ffce0e) Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com>
* fix(reports): error generating group reports due to accessing to a property of undefined - Fixed an error due to accessing to a property of undefined when the API request to get the group configuration failed due to token expiration or another error. - Changed styles of `Agents in groups` title - Fixed a problem with missing agents in the table for a group report. Now it gets all the agents. - Removed unnecessary API request - Optimized API requests to get the agent information required to print the agents in group's table - Removed `manager_host` deprecated field: - Removed of monitoring template mapping - Removed field meaning - Removed displaying its value reports if the field `manager` doesn't exist * changelog: add PR entry * fix(reporting): replaced parameter type * fix(reporting): replaced message when there are no agent in group Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 8ffce0e)
Fixed errors in group reports (#4350) * fix(reports): error generating group reports due to accessing to a property of undefined - Fixed an error due to accessing to a property of undefined when the API request to get the group configuration failed due to token expiration or another error. - Changed styles of `Agents in groups` title - Fixed a problem with missing agents in the table for a group report. Now it gets all the agents. - Removed unnecessary API request - Optimized API requests to get the agent information required to print the agents in group's table - Removed `manager_host` deprecated field: - Removed of monitoring template mapping - Removed field meaning - Removed displaying its value reports if the field `manager` doesn't exist * changelog: add PR entry * fix(reporting): replaced parameter type * fix(reporting): replaced message when there are no agent in group Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 8ffce0e)
Description
This PRs fixes some problems when generating a group reports:
Closes #4348
Changes
Agents in groups
titleNow it gets all the agents.
the agents in group's table
manager_host
deprecated field (more information):manager
doesn't existTest
Manual tests
Scenario: Error due to accessing to a property of undefined
Given: Logged user in Management/Groups//Information, wait the time to the Wazuh API token expires.
When: The user click on "Export PDF" button.
Then: The PDF should be generated without errors. Check the generated PDF.
Scenario: Missing agents in the agent in group table of group report.
Given: group with more than 500 agents.
When: The user clicks on "Export PDF" button.
Then: The PDF should be genrated without errors and it should contains all the agents in the group displayed in a table.