Fixed errors in group reports #4350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…operty of undefined - Fixed an error due to accessing to a property of undefined when the API request to get the group configuration failed due to token expiration or another error. - Changed styles of `Agents in groups` title - Fixed a problem with missing agents in the table for a group report. Now it gets all the agents. - Removed unnecessary API request - Optimized API requests to get the agent information required to print the agents in group's table - Removed `manager_host` deprecated field: - Removed of monitoring template mapping - Removed field meaning - Removed displaying its value reports if the field `manager` doesn't exist
Desvelao
force-pushed
the
fix/4348-error-generate-group-reports
branch
from
36907b9
to
5554910
Compare
AlexRuiz7
suggested changes
Jul 22, 2022
|
github-actions bot
pushed a commit
that referenced
this pull request
Aug 5, 2022
* fix(reports): error generating group reports due to accessing to a property of undefined - Fixed an error due to accessing to a property of undefined when the API request to get the group configuration failed due to token expiration or another error. - Changed styles of `Agents in groups` title - Fixed a problem with missing agents in the table for a group report. Now it gets all the agents. - Removed unnecessary API request - Optimized API requests to get the agent information required to print the agents in group's table - Removed `manager_host` deprecated field: - Removed of monitoring template mapping - Removed field meaning - Removed displaying its value reports if the field `manager` doesn't exist * changelog: add PR entry * fix(reporting): replaced parameter type * fix(reporting): replaced message when there are no agent in group Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 8ffce0e)
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.3-1.2-wzd 4.3-1.2-wzd
# Navigate to the new working tree
cd .worktrees/backport-4.3-1.2-wzd
# Create a new branch
git switch --create backport-4350-to-4.3-1.2-wzd
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8ffce0ea89f6ba534cfb20f6a26301d264a528fb
# Push it to GitHub
git push --set-upstream origin backport-4350-to-4.3-1.2-wzd
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.3-1.2-wzdThen, create a pull request where the |
Desvelao
added a commit
that referenced
this pull request
Aug 5, 2022
Fixed errors in group reports (#4350) * fix(reports): error generating group reports due to accessing to a property of undefined - Fixed an error due to accessing to a property of undefined when the API request to get the group configuration failed due to token expiration or another error. - Changed styles of `Agents in groups` title - Fixed a problem with missing agents in the table for a group report. Now it gets all the agents. - Removed unnecessary API request - Optimized API requests to get the agent information required to print the agents in group's table - Removed `manager_host` deprecated field: - Removed of monitoring template mapping - Removed field meaning - Removed displaying its value reports if the field `manager` doesn't exist * changelog: add PR entry * fix(reporting): replaced parameter type * fix(reporting): replaced message when there are no agent in group Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 8ffce0e) Co-authored-by: Antonio <34042064+Desvelao@users.noreply.github.com>
Desvelao
added a commit
that referenced
this pull request
Aug 5, 2022
* fix(reports): error generating group reports due to accessing to a property of undefined - Fixed an error due to accessing to a property of undefined when the API request to get the group configuration failed due to token expiration or another error. - Changed styles of `Agents in groups` title - Fixed a problem with missing agents in the table for a group report. Now it gets all the agents. - Removed unnecessary API request - Optimized API requests to get the agent information required to print the agents in group's table - Removed `manager_host` deprecated field: - Removed of monitoring template mapping - Removed field meaning - Removed displaying its value reports if the field `manager` doesn't exist * changelog: add PR entry * fix(reporting): replaced parameter type * fix(reporting): replaced message when there are no agent in group Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 8ffce0e)
Desvelao
added a commit
that referenced
this pull request
Aug 5, 2022
Fixed errors in group reports (#4350) * fix(reports): error generating group reports due to accessing to a property of undefined - Fixed an error due to accessing to a property of undefined when the API request to get the group configuration failed due to token expiration or another error. - Changed styles of `Agents in groups` title - Fixed a problem with missing agents in the table for a group report. Now it gets all the agents. - Removed unnecessary API request - Optimized API requests to get the agent information required to print the agents in group's table - Removed `manager_host` deprecated field: - Removed of monitoring template mapping - Removed field meaning - Removed displaying its value reports if the field `manager` doesn't exist * changelog: add PR entry * fix(reporting): replaced parameter type * fix(reporting): replaced message when there are no agent in group Co-authored-by: Álex <alejandro.ruiz.becerra@wazuh.com> (cherry picked from commit 8ffce0e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PRs fixes some problems when generating a group reports:
Closes #4348
Changes
Agents in groupstitleNow it gets all the agents.
the agents in group's table
manager_hostdeprecated field (more information):managerdoesn't existTest
Manual tests
Scenario: Error due to accessing to a property of undefined
Given: Logged user in Management/Groups//Information, wait the time to the Wazuh API token expires.
When: The user click on "Export PDF" button.
Then: The PDF should be generated without errors. Check the generated PDF.
Scenario: Missing agents in the agent in group table of group report.
Given: group with more than 500 agents.
When: The user clicks on "Export PDF" button.
Then: The PDF should be genrated without errors and it should contains all the agents in the group displayed in a table.