Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.4] Add os.uname and os.version fields to agents table #5076

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Jan 5, 2023

Description

Team,
this PR adds os.uname and os.version fields to the required /agents request for the agents overview table. With this information the table can render the agent OS icon and the agent OS version in the OS column

Issues Resolved

Closes #5073

Related to #4363

Evidence

image

Test

Register Linux / Windows agents in the manager
Check the agent OS icon and version are shown

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this Jan 5, 2023
@asteriscos asteriscos requested a review from a team as a code owner January 5, 2023 12:39
@asteriscos asteriscos linked an issue Jan 5, 2023 that may be closed by this pull request
chantal-kelm
chantal-kelm previously approved these changes Jan 5, 2023
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
TEST: ✅

Evidence:

image

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

Code coverage (Jest) % values
Statements 8.72% ( 3224 / 36951 )
Branches 4.55% ( 1306 / 28687 )
Functions 7.61% ( 698 / 9161 )
Lines 8.78% ( 3109 / 35382 )

@chantal-kelm chantal-kelm self-requested a review January 5, 2023 14:54
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
TEST: ✅

Evidence:

image

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexRuiz7 AlexRuiz7 merged commit 9faec09 into 4.4-2.4-wzd Jan 9, 2023
@AlexRuiz7 AlexRuiz7 deleted the backport-2.4-wzd/add-os.uname-and-os.version-fields-to-agents-table-5073 branch January 9, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agents table has no OS icon or OS version
4 participants