-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix visual error in "About" section #5337
Conversation
Wazuh dashboardLegend: UI
Details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review
🟢 code
🟢 test #5337 (comment)
Wazuh dashboardLegend: UI
Details 🟢 The Welcome to the Wazuh dashboard and Community panels in Settings/About should not reach the horizontal end of the screen on any of the sidesChrome - 🟢 Firefox - 🟢 The icons for Slack, Google Groups and GitHub are next to each other and used to have a margin. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wazuh dashboard
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
Test | Chrome | Firefox |
---|---|---|
The Welcome to the Wazuh dashboard and Community panels in Settings/About should not reach the horizontal end of the screen on any of the sides | 🟢 | 🟢 |
Details
🟢 The Welcome to the Wazuh dashboard and Community panels in Settings/About should not reach the horizontal end of the screen on any of the sides
Chrome - 🟢
Firefox - 🟢
The icons for Slack, Google Groups and GitHub are next to each other and used to have a margin.
Description
This PR aims to solve a visual error presented in the
About
sectionIssues Resolved
#5336
Evidence
Before:
![imagen](https://user-images.githubusercontent.com/42900763/228680707-5ea899cc-3010-4bc3-9154-98d894b3f21d.png)
After:
![image](https://user-images.githubusercontent.com/63758389/228796315-b957fbb2-1049-4fc1-b72d-a374157b35ca.png)
Test
Navigate to Settings/About and confirm that the
Welcome to the Wazuh dashboard
andCommunity
containers, and the blue bar that contains theApp version
,App revision
andInstall date
on top of them doesn't reach the horizontal end of the screen in any of the sidesCheck List
yarn test:jest