Fix visual error in "About" section #5337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wazuh dashboardLegend: UI
Details 🟢 The Welcome to the Wazuh dashboard and Community panels in Settings/About should not reach the horizontal end of the screen on any of the sidesChrome - 🟢 Firefox - 🟢 |
Desvelao
previously approved these changes
Mar 30, 2023
Wazuh dashboardLegend: UI
Details 🟢 The Welcome to the Wazuh dashboard and Community panels in Settings/About should not reach the horizontal end of the screen on any of the sidesChrome - 🟢
Firefox - 🟢
The icons for Slack, Google Groups and GitHub are next to each other and used to have a margin. |
yenienserrano
previously approved these changes
Mar 30, 2023
AlexRuiz7
previously approved these changes
Mar 30, 2023
|
yenienserrano
approved these changes
Mar 30, 2023
Machi3mfl
approved these changes
Mar 30, 2023
There was a problem hiding this comment.
Wazuh dashboard
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
| Test | Chrome | Firefox |
|---|---|---|
| The Welcome to the Wazuh dashboard and Community panels in Settings/About should not reach the horizontal end of the screen on any of the sides | 🟢 | 🟢 |
Details
🟢 The Welcome to the Wazuh dashboard and Community panels in Settings/About should not reach the horizontal end of the screen on any of the sides
Chrome - 🟢
Firefox - 🟢
The icons for Slack, Google Groups and GitHub are next to each other and used to have a margin.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to solve a visual error presented in the
AboutsectionIssues Resolved
#5336
Evidence
Before:
After:
Test
Navigate to Settings/About and confirm that the
Welcome to the Wazuh dashboardandCommunitycontainers, and the blue bar that contains theApp version,App revisionandInstall dateon top of them doesn't reach the horizontal end of the screen in any of the sidesCheck List
yarn test:jest