Wazuh api usage magement/status #5528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tostti
previously approved these changes
Jun 6, 2023
There was a problem hiding this comment.
Test
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
| Test | Chrome | Firefox | Safari |
|---|---|---|---|
Navigate to management status and do not see the request GET /agents/summary/status |
🟢 | 🟢 | ⚫ |
Navigate to management status and do not see the request GET /agents" with parameters {"limit": "1", "sort": "-dateAdd", "q": "id!=000"} |
🟢 | 🟢 | ⚫ |
In cluster mode do not see the request GET /manager/info |
🟢 | 🟢 | ⚫ |
In manager mode see the request GET /manager/info |
🟢 | 🟢 | ⚫ |
when you change the node you do not have to see the request GET /agents/summary/status |
🟢 | 🟢 | ⚫ |
when you change the node you do not have to see the request GET /agents" with parameters {"limit": "1", "sort": "-dateAdd", "q": "id!=000"} |
🟢 | 🟢 | ⚫ |
Details
🟢 Navigate to management status and do not see the request `GET /agents/summary/status`
Chrome - 🟢
Firefox - 🟢
Safari - ⚫
🟢 Navigate to management status and do not see the request `GET /agents" with parameters {"limit": "1", "sort": "-dateAdd", "q": "id!=000"}`
Chrome - 🟢
Firefox - 🟢
Safari - ⚫
🟢 In cluster mode do not see the request `GET /manager/info`
Chrome - 🟢
Firefox - 🟢
Safari - ⚫
🟢 In manager mode see the request `GET /manager/info`
Chrome - 🟢
Firefox - 🟢
Safari - ⚫
🟢 when you change the node you do not have to see the request `GET /agents/summary/status`
Chrome - 🟢
Firefox - 🟢
Safari - ⚫
🟢when you change the node you do not have to see the request `GET /agents" with parameters {"limit": "1", "sort": "-dateAdd", "q": "id!=000"}`
Chrome - 🟢
Firefox - 🟢
Safari - ⚫
TEST:✔️
CR:✔️
LGTM
Desvelao
reviewed
Jun 6, 2023
public/controllers/management/components/management/status/actions-buttons-main.js
Outdated
Show resolved
Hide resolved
Desvelao
reviewed
Jun 6, 2023
public/controllers/management/components/management/status/status-overview.js
Outdated
Show resolved
Hide resolved
Desvelao
reviewed
Jun 6, 2023
public/controllers/management/components/management/status/status-overview.js
Show resolved
Hide resolved
|
TestLegend: UI
Details 🟢 Navigate to management status and do not see the request `GET /agents/summary/status`Chrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 Navigate to management status and do not see the request `GET /agents" with parameters {"limit": "1", "sort": "-dateAdd", "q": "id!=000"}`Chrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 In cluster mode do not see the request `GET /manager/info`Chrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 In manager mode see the request `GET /manager/info`Chrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 when you change the node you do not have to see the request `GET /agents/summary/status`Chrome - 🟢 Firefox - ⚫ Safari - ⚫ 🟢 when you change the node you do not have to see the request `GET /agents" with parameters {"limit": "1", "sort": "-dateAdd", "q": "id!=000"}`Chrome - 🟢 Firefox - ⚫ Safari - ⚫ |
Desvelao
approved these changes
Jun 7, 2023
AlexRuiz7
approved these changes
Jun 7, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jun 7, 2023
* Add imposter * Changes when clicking on the status section * Changes when changing to another node to see its status * Add changelog * Check is NaN (cherry picked from commit db2cce4)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 7, 2023
* Add imposter * Changes when clicking on the status section * Changes when changing to another node to see its status * Add changelog * Check is NaN (cherry picked from commit db2cce4)
asteriscos
pushed a commit
that referenced
this pull request
Jun 9, 2023
Wazuh api usage magement/status (#5528) * Add imposter * Changes when clicking on the status section * Changes when changing to another node to see its status * Add changelog * Check is NaN (cherry picked from commit db2cce4) Co-authored-by: Ian Yenien Serrano <63758389+yenienserrano@users.noreply.github.com>
asteriscos
pushed a commit
that referenced
this pull request
Jun 9, 2023
Wazuh api usage magement/status (#5528) * Add imposter * Changes when clicking on the status section * Changes when changing to another node to see its status * Add changelog * Check is NaN (cherry picked from commit db2cce4) Co-authored-by: Ian Yenien Serrano <63758389+yenienserrano@users.noreply.github.com>
8 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unnecessary requests have been eliminated
Issues Resolved
Evidence
Before
After
Test
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
GET /agents/summary/statusGET /agents" with parameters {"limit": "1", "sort": "-dateAdd", "q": "id!=000"}GET /manager/infoGET /manager/infoGET /agents/summary/statusGET /agents" with parameters {"limit": "1", "sort": "-dateAdd", "q": "id!=000"}Details
⚫ Navigate to management status and do not see the request `GET /agents/summary/status`
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Navigate to management status and do not see the request `GET /agents" with parameters {"limit": "1", "sort": "-dateAdd", "q": "id!=000"}`
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ In cluster mode do not see the request `GET /manager/info`
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ In manager mode see the request `GET /manager/info`
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ when you change the node you do not have to see the request `GET /agents/summary/status`
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ when you change the node you do not have to see the request `GET /agents" with parameters {"limit": "1", "sort": "-dateAdd", "q": "id!=000"}`
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
Check List
yarn test:jest