Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ?pretty of request #5532

Merged
merged 3 commits into from
Jun 7, 2023
Merged

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Jun 6, 2023

Description

Pretty of the request is removed

Issues Resolved

Evidence

image

Test

Wait for the job to run and see in the imposter or manager logs that the ?pretty is not there

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano requested a review from a team as a code owner June 6, 2023 15:32
@yenienserrano yenienserrano linked an issue Jun 6, 2023 that may be closed by this pull request
@Desvelao
Copy link
Member

Desvelao commented Jun 7, 2023

Wazuh dashboard

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

Other

Test Result
Wait for the job to run and see in the imposter or manager logs that the ?pretty is not there 🟢

Details

🟢 Wait for the job to run and see in the imposter or manager logs that the ?pretty is not there

image

Desvelao
Desvelao previously approved these changes Jun 7, 2023
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review:

code 🟢
test 🟢 #5532 (comment)

AlexRuiz7
AlexRuiz7 previously approved these changes Jun 7, 2023
@AlexRuiz7 AlexRuiz7 dismissed stale reviews from Desvelao and themself via 699671a June 7, 2023 11:33
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

Code coverage (Jest) % values
Statements 9.52% ( 3506 / 36822 )
Branches 5.02% ( 1434 / 28527 )
Functions 8.18% ( 747 / 9122 )
Lines 9.6% ( 3386 / 35269 )

@AlexRuiz7 AlexRuiz7 merged commit c39128a into 4.5 Jun 7, 2023
3 checks passed
@AlexRuiz7 AlexRuiz7 deleted the 5247-wazuh-api-usage-statistics-task branch June 7, 2023 11:53
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

The backport to 4.5-7.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.5-7.10 4.5-7.10
# Navigate to the new working tree
cd .worktrees/backport-4.5-7.10
# Create a new branch
git switch --create backport-5532-to-4.5-7.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c39128af39c1194e05d0e6520aa77bffa77586ca
# Push it to GitHub
git push --set-upstream origin backport-5532-to-4.5-7.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.5-7.10

Then, create a pull request where the base branch is 4.5-7.10 and the compare/head branch is backport-5532-to-4.5-7.10.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

The backport to 4.5-7.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.5-7.16 4.5-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.5-7.16
# Create a new branch
git switch --create backport-5532-to-4.5-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c39128af39c1194e05d0e6520aa77bffa77586ca
# Push it to GitHub
git push --set-upstream origin backport-5532-to-4.5-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.5-7.16

Then, create a pull request where the base branch is 4.5-7.16 and the compare/head branch is backport-5532-to-4.5-7.16.

yenienserrano added a commit that referenced this pull request Jun 8, 2023
* Remove ?pretty of request

* Add changelog

---------

Co-authored-by: Álex Ruiz <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit c39128a)
yenienserrano added a commit that referenced this pull request Jun 8, 2023
* Remove ?pretty of request

* Add changelog

---------

Co-authored-by: Álex Ruiz <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit c39128a)
asteriscos added a commit that referenced this pull request Jun 9, 2023
Remove `?pretty` of request (#5532)

* Remove ?pretty of request

* Add changelog

---------

Co-authored-by: Álex Ruiz <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit c39128a)

Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
asteriscos added a commit that referenced this pull request Jun 9, 2023
Remove `?pretty` of request (#5532)

* Remove ?pretty of request

* Add changelog

---------

Co-authored-by: Álex Ruiz <alejandro.ruiz.becerra@wazuh.com>
(cherry picked from commit c39128a)

Co-authored-by: Federico Rodriguez <federico.rodriguez@wazuh.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wazuh API usage - Statistics task
3 participants