Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong filter button in Management > Decoders > Manage decoders files #5813

Merged
merged 4 commits into from
Sep 1, 2023
Merged

Fix wrong filter button in Management > Decoders > Manage decoders files #5813

merged 4 commits into from
Sep 1, 2023

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Aug 25, 2023 •
edited

Description

This pull requests fixes a filter button in Management > Decoders > Manage decoders files.

Changes:

  • label and filter of button

Side changes:

  • Removed unused buttonOptions property in Management > Rules

Issues Resolved

#5812

Evidence

image
image

Test

[Provide instructions to test this PR]

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Desvelao Desvelao requested a review from a team as a code owner August 25, 2023 06:46
@Desvelao Desvelao self-assigned this Aug 25, 2023
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 11.48% ( 3959 / 34485 )
Branches 7.57% ( 1775 / 23422 )
Functions 10.86% ( 896 / 8246 )
Lines 11.66% ( 3847 / 32980 )

@Tostti Tostti linked an issue Aug 25, 2023 that may be closed by this pull request
Fix the filter button in Management > Decoders > Manage decoders files #5812
Closed
@JuanGarriuz JuanGarriuz self-requested a review August 28, 2023 06:24
@JuanGarriuz
Copy link
Member

Test UI

image
image

JuanGarriuz
JuanGarriuz approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

asteriscos
asteriscos approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: ✔️
CR: ✔️

image

@asteriscos asteriscos merged commit 923e5ed into 4.6.0 Sep 1, 2023
2 checks passed
@asteriscos asteriscos deleted the fix/5812-custom-decoders-filter branch September 1, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

@JuanGarriuz JuanGarriuz JuanGarriuz approved these changes

Assignees

@Desvelao Desvelao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the filter button in Management > Decoders > Manage decoders files
3 participants
@Desvelao @JuanGarriuz @asteriscos