Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix agent name validation #6105

Merged
merged 6 commits into from
Nov 8, 2023
Merged

Fix agent name validation #6105

merged 6 commits into from
Nov 8, 2023

Conversation

Tostti
Copy link
Member

@Tostti Tostti commented Nov 7, 2023

Description

This PR aims to fix an incorrect validation of the agent name in the Deploy new agent window, that prevents the use of numeric characters.

Issues Resolved

#6029

Evidence

image

Test

  • Navigate to the Deploy new agent section and verify that the agent name is correctly validated. It must allow A-Z, a-z, 0-9, .,-,_.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Tostti Tostti self-assigned this Nov 7, 2023
@Tostti Tostti linked an issue Nov 7, 2023 that may be closed by this pull request
Incorrect agent name validation: numeric characters should be allowed #6029
Closed
@Tostti Tostti marked this pull request as ready for review November 8, 2023 12:09
@Tostti Tostti requested a review from a team as a code owner November 8, 2023 12:09
@yenienserrano yenienserrano self-requested a review November 8, 2023 12:44
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Code coverage (Jest) % values
Statements 11.72% ( 4044 / 34490 )
Branches 7.95% ( 1853 / 23289 )
Functions 11.23% ( 927 / 8248 )
Lines 11.9% ( 3932 / 33029 )

yenienserrano
yenienserrano approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

Desvelao
Desvelao approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tostti Tostti merged commit 2737506 into 4.7.1 Nov 8, 2023
2 checks passed
@Tostti Tostti deleted the 6029-incorrect-agent-name-validation branch November 8, 2023 16:20
@davidcr01 davidcr01 mentioned this pull request Nov 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

@yenienserrano yenienserrano yenienserrano approved these changes

Assignees

@Tostti Tostti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect agent name validation: numeric characters should be allowed
3 participants
@Tostti @Desvelao @yenienserrano