-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace discover AWS #6288
Replace discover AWS #6288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests
Search bar
Test | Chrome | Firefox | Safari |
---|---|---|---|
Apply filters using search bar input | 🟢 | ⚫ | ⚫ |
Apply filters using the search bar add filter feature |
🟢 | ⚫ | ⚫ |
Apply filters using the date picker | 🟢 | ⚫ | ⚫ |
Apply filters with no results (Check the No results match your search criteria message) |
🟢 | ⚫ | ⚫ |
Use the saved queries feature (Check saved queries CRUD) |
🟢 | ⚫ | ⚫ |
- Apply filters using search bar input
Screen.Recording.2024-01-10.at.14.18.28.mov
- Apply filters using the search bar
add filter
feature
Screen.Recording.2024-01-10.at.14.20.50.mov
- Apply filters using the date picker
Screen.Recording.2024-01-10.at.14.22.03.mov
- Apply filters with no results (Check the
No results match your search criteria
message)
Screen.Recording.2024-01-10.at.14.17.30.mov
- Use the
saved queries
feature (Check saved queries CRUD)
Screen.Recording.2024-01-10.at.14.22.53.mov
Histogram chart
Test | Chrome | Firefox | Safari |
---|---|---|---|
Check histogram chart hits consistency | 🟢 | ⚫ | ⚫ |
Use chart options (three points: maximize, minimize, inspect) | 🟢 | ⚫ | ⚫ |
- Check histogram chart hits consistency
Screen.Recording.2024-01-10.at.14.24.15.mov
- Use chart options (three points: maximize, minimize, inspect)
Screen.Recording.2024-01-10.at.14.25.30.mov
Data grid
Test | Chrome | Firefox | Safari |
---|---|---|---|
Check all table header features (sort, show/hide columns, density, etc) | 🟢 | ⚫ | ⚫ |
Check table pagination and rows per page | 🟢 | ⚫ | ⚫ |
Check document detail flyout | 🟢 | ⚫ | ⚫ |
- Check all table header features (sort, show/hide columns, density, etc)
Screen.Recording.2024-01-10.at.14.27.00.mov
- Check table pagination and rows per page
Screen.Recording.2024-01-10.at.14.28.56.mov
- Check document detail flyout
|
|
|
nice, @yenienserrano. Good job ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR ✅
Testing ✅
TestsSearch bar
Histogram chart
Data grid
Video_2024-02-15_12-22-50.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test ✅
CR ✅
LGTM
Description
This PR, replaces the events tab on the Amazon Web Services module
Issues Resolved
Evidence
Tests
Search bar
add filter
featureNo results match your search criteria
message)saved queries
feature (Check saved queries CRUD)add filter
featureNo results match your search criteria
message)saved queries
feature (Check saved queries CRUD)Histogram chart
Data grid
Check List
yarn test:jest