New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix maximize in embeddable vulnerability panel #6330
Merged
asteriscos
merged 4 commits into
4.8.0
from
6322-maximized-visualizations-not-display-properly-in-vulnerabilities-dashboard
Jan 18, 2024
Merged
Fix maximize in embeddable vulnerability panel #6330
asteriscos
merged 4 commits into
4.8.0
from
6322-maximized-visualizations-not-display-properly-in-vulnerabilities-dashboard
Jan 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roperly-in-vulnerabilities-dashboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…roperly-in-vulnerabilities-dashboard
|
|
yenienserrano
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
JuanGarriuz
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
asteriscos
deleted the
6322-maximized-visualizations-not-display-properly-in-vulnerabilities-dashboard
branch
January 18, 2024 10:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fix maximize in embeddable dashboards panels.
dshLayout-isMaximizedPanel
is a specific class that adds OSD to the ResponsiveGrid component when a panel is expanded.Since this fix is needed in more than one embedded dashboard, it was decided to apply the CSS at the highest possible level but within the context of Wazuh.
Issues Resolved
Evidence
Evidence.webm
Test
Note
This test requires data to be inserted into the vulnerability index via the dataInjectScript.py script located in scripts/vulnerabilities-events-injector
Steps to test:
Check List
yarn test:jest