Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maximize in embeddable vulnerability panel #6330

Conversation

jbiset
Copy link
Member

@jbiset jbiset commented Jan 16, 2024

Description

This pull request fix maximize in embeddable dashboards panels.
dshLayout-isMaximizedPanel is a specific class that adds OSD to the ResponsiveGrid component when a panel is expanded.
Since this fix is needed in more than one embedded dashboard, it was decided to apply the CSS at the highest possible level but within the context of Wazuh.

Issues Resolved

Evidence

Evidence.webm

Test

Note

This test requires data to be inserted into the vulnerability index via the dataInjectScript.py script located in scripts/vulnerabilities-events-injector

Steps to test:

  • Go to vulnerability module.
  • Go to panel actions of a panel ("···" button)
  • Select maximize panel.
  • The panel occupy the entire space of the module.
  • Check correct operation with the menu bar

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@jbiset jbiset requested a review from a team as a code owner January 16, 2024 19:26
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅ Should it be in the changelog?
Test: ✅

Screenshots

image
image
image
image

Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 21.42% ( 186 / 868 )
Branches 17.99% ( 79 / 439 )
Functions 14.22% ( 36 / 253 )
Lines 21.65% ( 183 / 845 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.68% ( 171 / 223 )
Branches 57.57% ( 57 / 99 )
Functions 61.7% ( 29 / 47 )
Lines 76.68% ( 171 / 223 )

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.2% ( 4202 / 34417 )
Branches 8.26% ( 1911 / 23121 )
Functions 11.71% ( 958 / 8176 )
Lines 12.38% ( 4087 / 33008 )

@JuanGarriuz
Copy link
Member

Tests ✅

image

image

image

image

Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@asteriscos asteriscos merged commit cae72da into 4.8.0 Jan 18, 2024
4 checks passed
@asteriscos asteriscos deleted the 6322-maximized-visualizations-not-display-properly-in-vulnerabilities-dashboard branch January 18, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maximized visualizations don't display properly in vulnerabilities dashboard
4 participants