Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change api configuration title #6373

Merged
merged 4 commits into from
Jan 26, 2024
Merged

Change api configuration title #6373

merged 4 commits into from
Jan 26, 2024

Conversation

chantal-kelm
Copy link
Member

@chantal-kelm chantal-kelm commented Jan 24, 2024 •
edited by asteriscos

Description

Change api configuration title

Before

image (3)

Now

image (4)

Issues Resolved

#6369

Evidence

image (4)

Test

In the left side menu click on Server APIs and verify that the title has changed from API Configuration to API Connections.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@chantal-kelm chantal-kelm requested a review from a team as a code owner January 24, 2024 17:19
@chantal-kelm chantal-kelm linked an issue Jan 24, 2024 that may be closed by this pull request
Change API configuration title #6369
Closed
1 task
asteriscos
asteriscos approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

image

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 20.85% ( 186 / 892 )
Branches 17.91% ( 79 / 441 )
Functions 13.79% ( 36 / 261 )
Lines 21.05% ( 183 / 869 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 57.42% ( 58 / 101 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.22% ( 4207 / 34427 )
Branches 8.28% ( 1918 / 23140 )
Functions 11.72% ( 959 / 8177 )
Lines 12.39% ( 4092 / 33020 )

@lucianogorza lucianogorza self-requested a review January 25, 2024 19:06
lucianogorza
lucianogorza approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢

Test 🟢

image

@asteriscos asteriscos merged commit 6bd7ab7 into 4.8.0 Jan 26, 2024
4 checks passed
@asteriscos asteriscos deleted the 6369-Change-API-configuration-title branch January 26, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

@lucianogorza lucianogorza lucianogorza approved these changes

Assignees

@chantal-kelm chantal-kelm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change API configuration title
3 participants
@chantal-kelm @asteriscos @lucianogorza