Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizations #768

Merged
merged 18 commits into from
Aug 1, 2018
Merged

Optimizations #768

merged 18 commits into from
Aug 1, 2018

Conversation

jesusgn90
Copy link
Contributor

Closes #767

This PR removes some NPM modules, unused images, unused dependencies. Also it refactors route resolves module.

Note: if this PR is not merged, we should cherry-pick commit 7f27e01 cause it fixes a little bug

Regards,
Jesús

@jesusgn90 jesusgn90 added the type/enhancement Enhancement issue label Jul 31, 2018
@jesusgn90 jesusgn90 self-assigned this Jul 31, 2018
@jesusgn90 jesusgn90 added this to Pending in Revision 405 via automation Jul 31, 2018
@jesusgn90 jesusgn90 mentioned this pull request Jul 31, 2018
@havidarou
Copy link
Member

LGTM!

@havidarou havidarou merged commit 2fd4484 into 3.4-6.3 Aug 1, 2018
Revision 405 automation moved this from Pending to Testing Aug 1, 2018
@havidarou havidarou deleted the issue-767 branch August 1, 2018 18:10
@JuanjiJG JuanjiJG moved this from Testing to Done in Revision 405 Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Enhancement issue
Projects
No open projects
Revision 405
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants