Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client side refactor #802

Merged
merged 2 commits into from
Aug 24, 2018
Merged

Client side refactor #802

merged 2 commits into from
Aug 24, 2018

Conversation

jesusgn90
Copy link
Contributor

Hello team, this PR is a first approach of #797

Main changes

  • This PR mainly changes public/ folder structure.
  • Removes outdated names such osseclog
  • Splits each controller into separated files
  • Migrates services and some controllers to ES6 class paradigm
  • Optimizes some lines of code
  • Removes some unused dependencies
  • Reduces the rootScope usage
  • Adds comments to multiple functions (we have still uncommented functions)
  • Removes a check from the Logger initialization regarding to plugins/ folder because it's no longer needed. This allow us to run again the app under plugins folder while developing.

Note 1: Using classes instead anonymous functions will help us to future framework migration, usability, code maintenance, readability ...

Note 2: this PR should be merged ASAP due to structure changes, this way we can avoid future conflicts in further PRs.

Note 3: internal logic has not been modified, this PR modifies lot of files but it doesn't change current logic.

Regards,
Jesús

@jesusgn90 jesusgn90 added the type/enhancement Enhancement issue label Aug 20, 2018
@jesusgn90 jesusgn90 added this to Pending in Revision 405 via automation Aug 20, 2018
@jesusgn90 jesusgn90 mentioned this pull request Aug 20, 2018
@JuanjiJG
Copy link
Contributor

This PR would be a really good starting point for new big features such as the Management > Configuration redesign.

Amazing work @jesusgn90! 😄

@havidarou
Copy link
Member

LGTM! Amazing work!!

@havidarou havidarou merged commit e996910 into 3.5-6.3 Aug 24, 2018
Revision 405 automation moved this from Pending feature to Feature testing Aug 24, 2018
@jesusgn90 jesusgn90 deleted the rename branch August 24, 2018 16:10
@jesusgn90 jesusgn90 moved this from Feature testing to Done in Revision 405 Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Enhancement issue
Projects
No open projects
Revision 405
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants