Code quality(eslint, mocha, tslint) #859
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello team, this PR is a first approach for giving code quality to our App. Added some Mocha tests, validated eslint for the current code (0 warnings, 0 errors), added basic tslint. Modified some code lines to be more "best practices".
From now and onwards, we must validate eslint and pass the mocha tests for each PR.
Closes #858
Regards,
Jesús