-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make syscollector capable to fetch the PYPI and node packages #6346
Conversation
source/user-manual/capabilities/system-inventory/compatibility-matrix.rst
Outdated
Show resolved
Hide resolved
source/user-manual/capabilities/system-inventory/compatibility-matrix.rst
Outdated
Show resolved
Hide resolved
source/user-manual/capabilities/system-inventory/compatibility-matrix.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gj!
source/user-manual/capabilities/system-inventory/compatibility-matrix.rst
Outdated
Show resolved
Hide resolved
Delete duplicate https. Specify about enhancement.
source/user-manual/capabilities/system-inventory/compatibility-matrix.rst
Outdated
Show resolved
Hide resolved
source/user-manual/capabilities/system-inventory/compatibility-matrix.rst
Outdated
Show resolved
Hide resolved
Fix link PyPI
+------------------------+----------------------+-----------------+ | ||
| macOS | √ | √ | | ||
+------------------------+----------------------+-----------------+ | ||
| FreeBSD | ✗ | ✗ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure that freebsd and solaris do not have support for those package managers?
Some questions and comments: Why a limited list of package formats? Why not having the full list of packages including already supported plus these newly supported formats? The specific table for the package scan could simply be a two-columns table: First column listing supported operating systems and second column with an enumeration of supported package formats such as What about updating the Available inventory fields? I think we have to update the enumerated formats there too because this version has a broader reach. We could even enumerate here once again all the supported packages, if this were possible. What do you think about providing a list of all the supported package formats everywhere where it's required? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ
Add packages support in available-inventory-fields.
|
||
The Syscollector module now supports scan packages from `NPM (Node Package Manager) <https://www.npmjs.com/>`_ and `PyPI (Python Package Index) <https://pypi.org/>`_, **the support is only for the default paths of those packages' installation**. | ||
|
||
The following table shows the new feature that are compatible with various operating systems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are talking about "the new feature" I think it should be "...is compatible..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree :)
| | NPM | PyPI | rpm | deb | pacman | pkg | .pkg | | ||
+------------------------+----------------------+-----------------+-----------------+------------------+------------------+-----------------+-----------------+ | ||
| Windows | √ | √ | – | – | – | – | – | | ||
+------------------------+----------------------+-----------------+-----------------+------------------+------------------+-----------------+-----------------+ | ||
| Linux | √ | √ | √ | √ | √ | √ | – | | ||
+------------------------+----------------------+-----------------+-----------------+------------------+------------------+-----------------+-----------------+ | ||
| macOS | √ | √ | – | – | – | – | – | | ||
+------------------------+----------------------+-----------------+-----------------+------------------+------------------+-----------------+-----------------+ | ||
| FreeBSD | √ | √ | – | – | – | – | – | | ||
+------------------------+----------------------+-----------------+-----------------+------------------+------------------+-----------------+-----------------+ | ||
| OpenBSD | √ | √ | – | – | – | – | – | | ||
+------------------------+----------------------+-----------------+-----------------+------------------+------------------+-----------------+-----------------+ | ||
| Solaris | √ | √ | – | – | – | – | √ | | ||
+------------------------+----------------------+-----------------+-----------------+------------------+------------------+-----------------+-----------------+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch ! Fix it !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some concerns
Move note about C++ before matrix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR closes #6342 by adding documentation about new package scanner support of syscollector (wazuh/wazuh#5443).
Checks
Docs building
Code formatting and web optimization
redirects.js
script if necessary (check this guide).Writing style
code
font for Bash commands, file names, REST paths, and code.