Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Azure Storage container name and remove path #6835

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

fdalmaup
Copy link
Member

@fdalmaup fdalmaup commented Dec 7, 2023

Description

Closes #6563. Removes the use of the container/path option and changes the container name in the Azure Storage use case to keep consistency with the values shown in the images. This option is not mandatory, so the user can learn about it in the Azure module reference.

Checks

Docs building

  • Compiles without warnings.

Code formatting and web optimization

  • Uses three spaces indentation.
  • Adds or updates meta descriptions accordingly.
  • Updates the redirects.js script if necessary (check this guide).

Writing style

  • Uses present tense, active voice, and semi-formal registry.
  • Uses short, simple sentences.
  • Uses bold for user interface elements, italics for key terms or emphasis, and code font for Bash commands, file names, REST paths, and code.

@GGP1 GGP1 self-requested a review December 7, 2023 17:40
Copy link
Member

@GGP1 GGP1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue reported that the field <path> had no clear definition but it is explained in the reference page mentioned just below the example. An option could be to use <path>path-to-logs</path> but removing it is also a okay.

Copy link
Member

@GGP1 GGP1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fdalmaup fdalmaup self-assigned this Dec 7, 2023
@javimed javimed merged commit 3fb926e into master Dec 18, 2023
3 checks passed
@javimed javimed deleted the bug/6563-container-path-use branch December 18, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

No clear definition of the Path variable used in Azure Storage Integration
4 participants