Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logformat journald to localfile reference #7202

Merged
merged 4 commits into from
Apr 26, 2024
Merged

Add logformat journald to localfile reference #7202

merged 4 commits into from
Apr 26, 2024

Conversation

juliancnn
Copy link
Member

@juliancnn juliancnn commented Apr 16, 2024 •
edited by javimed
Loading

Closes #7201

Checks

Docs building

  • Compiles without warnings.

Code formatting and web optimization

  • Uses three spaces indentation.
  • Adds or updates meta descriptions accordingly.
  • Updates the redirects.js script if necessary (check this guide).

Writing style

  • Uses present tense, active voice, and semi-formal registry.
  • Uses short, simple sentences.
  • Uses bold for user interface elements, italics for key terms or emphasis, and code font for Bash commands, file names, REST paths, and code.

@juliancnn juliancnn self-assigned this Apr 16, 2024
@juliancnn juliancnn force-pushed the 7201-logcollector-journald-logformat-reference branch from b730895 to 1f5f7bd Compare April 16, 2024 13:48
@juliancnn juliancnn force-pushed the 7201-logcollector-journald-logformat-reference branch from 1f5f7bd to 51f7d99 Compare April 16, 2024 15:33
@JcabreraC JcabreraC linked an issue Apr 25, 2024 that may be closed by this pull request
Documenting journald Log Format Configuration in Logcollector #7201
Closed
4 tasks
JcabreraC
JcabreraC previously approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@JcabreraC JcabreraC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@javimed javimed added level/task Task issue type/enhancement Enhancement issue labels Apr 26, 2024
javimed
javimed requested changes Apr 26, 2024
View reviewed changes
Copy link
Member

@javimed javimed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about updating the User manual > Capabilities > Log data collection section? Is there at least an issue requesting to update this section?

source/user-manual/reference/ossec-conf/localfile.rst Outdated Show resolved Hide resolved
source/user-manual/reference/ossec-conf/localfile.rst Outdated Show resolved Hide resolved
source/user-manual/reference/ossec-conf/localfile.rst Outdated Show resolved Hide resolved
source/user-manual/reference/ossec-conf/localfile.rst Outdated Show resolved Hide resolved
source/user-manual/reference/ossec-conf/localfile.rst Outdated Show resolved Hide resolved
source/user-manual/reference/ossec-conf/localfile.rst Outdated Show resolved Hide resolved
source/user-manual/reference/ossec-conf/localfile.rst Outdated Show resolved Hide resolved
source/user-manual/reference/ossec-conf/localfile.rst Outdated Show resolved Hide resolved
source/user-manual/reference/ossec-conf/localfile.rst Outdated Show resolved Hide resolved
source/user-manual/reference/ossec-conf/localfile.rst Show resolved Hide resolved
juliancnn and others added 2 commits April 26, 2024 12:59
@juliancnn @javimed
Apply suggestions from code review
80679a9 
Thanks!, LGTM i accept all suggestions

Co-authored-by: Javier Medeot <javier.medeot@wazuh.com>
@juliancnn
Improve the filter description in localfile configuration
19830bc
javimed
javimed requested changes Apr 26, 2024
View reviewed changes
source/user-manual/reference/ossec-conf/localfile.rst Outdated Show resolved Hide resolved
source/user-manual/reference/ossec-conf/localfile.rst Outdated Show resolved Hide resolved
source/user-manual/reference/ossec-conf/localfile.rst Outdated Show resolved Hide resolved
source/user-manual/reference/ossec-conf/localfile.rst Outdated Show resolved Hide resolved
source/user-manual/reference/ossec-conf/localfile.rst Outdated Show resolved Hide resolved
source/user-manual/reference/ossec-conf/localfile.rst Show resolved Hide resolved
source/user-manual/reference/ossec-conf/localfile.rst Outdated Show resolved Hide resolved
source/user-manual/reference/ossec-conf/localfile.rst Outdated Show resolved Hide resolved
source/user-manual/reference/ossec-conf/localfile.rst Outdated Show resolved Hide resolved
source/user-manual/reference/ossec-conf/localfile.rst Outdated Show resolved Hide resolved
@juliancnn @javimed
Apply suggestions from code review
2d3750c 
Thanks for the feedback, I accept all your suggestions.

Co-authored-by: Javier Medeot <javier.medeot@wazuh.com>
@javimed
Copy link
Member

javimed commented Apr 26, 2024 •
edited by JcabreraC
Loading

Related issue: #7201

@javimed javimed merged commit 05965bf into 4.9.0 Apr 26, 2024
3 checks passed
@javimed javimed deleted the 7201-logcollector-journald-logformat-reference branch April 26, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javimed javimed javimed approved these changes

@JcabreraC JcabreraC Awaiting requested review from JcabreraC

Assignees

@juliancnn juliancnn

Labels
level/task Task issue type/enhancement Enhancement issue
Projects
No open projects
Release 4.9.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documenting journald Log Format Configuration in Logcollector
3 participants
@juliancnn @javimed @JcabreraC