Fix client keys Ownership for 3.7.x and previous versions #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ientKeysOwnerTo4.3
…ientKeysOwnerTo4.3
c-bordon
changed the title
alberpilot
suggested changes
Dec 28, 2021
| @@ -21,6 +21,9 @@ case "$1" in | |||
| install|upgrade) | |||
|
|
|||
| if [ "$1" = "upgrade" ]; then | |||
| if pgrep -f ossec-authd > /dev/null 2>&1; then | |||
There was a problem hiding this comment.
I.e: upgrade from 4.0.0 to 4.3.0, this code kills unnecessarily the ossec-authd daemon. This kill must be done only in those cases where none of the wazuh or ossec control stops works.
| @@ -183,6 +183,10 @@ if ! id -u wazuh > /dev/null 2>&1; then | |||
| fi | |||
|
|
|||
| # Stop the services to upgrade the package | |||
| if pgrep -f ossec-authd > /dev/null 2>&1; then | |||
|
New tests were run after the changes |
alberpilot
approved these changes
Dec 29, 2021
| @@ -280,6 +280,9 @@ case "$1" in | |||
| if [ -z "$(ls -A ${WAZUH_GLOBAL_TMP_DIR})" ]; then | |||
| rm -rf ${WAZUH_GLOBAL_TMP_DIR} | |||
| fi | |||
|
|
|||
| # change client.keys ownership | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ownership change process is moved so that it is the last thing to do in the upgrade process
A validation is added for the ossec-authd daemon, if it is started, the process is eliminated before the upgrade
Logs example
Tests
https://devel.ci.wazuh.info/view/Tests/job/Test_upgrade_tier/1496/consoleFull
%filessection is correctly updated if necessary%filessection is correctly updated if necessary