Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows resource information capability #13017

Merged
merged 2 commits into from Apr 5, 2022

Conversation

jnasselle
Copy link
Member

@jnasselle jnasselle commented Apr 1, 2022

Related issue
#12660
  • Add detailed information for Windows agent binaries and libraries.
  • Add version.rc file with default values and allowing to set some of
    them by defines
  • Add version.rc customization by bump_version.sh

Description

This PR allows setting common detailed information for windows agent's binaries and libraries, and at the same time enabling custom build version

Use examples

Default compilation

make -C src TARGET=winagent

Capture

Custom compilation

make -C src BUILD_VERSION="v4.4.0-commit123" TARGET=winagent

Capture2

Compilation after bump to 4.5.0

./bump_version.sh v4.5.0 -r 40500 -p 4.5.0.0
make -C src TARGET=winagent

Capture3

Tests

  • Compilation without warnings in every supported platform
    • Linux
    • Windows
    • MAC OS X
  • Source installation
  • Package installation
  • Source upgrade
  • Package upgrade
  • Review logs syntax and correct language
  • QA templates contemplate the added capabilities
  • Memory tests for Linux
    • Scan-build report
    • Coverity
    • Valgrind (memcheck and descriptor leaks check)
    • Dr. Memory
    • AddressSanitizer
  • Memory tests for Windows
    • Scan-build report
    • Coverity
    • Dr. Memory
  • Memory tests for macOS
    • Scan-build report
    • Leaks
    • AddressSanitizer
  • Retrocompatibility with older Wazuh versions
  • Working on cluster environments
  • Configuration on demand reports new parameters
  • The data flow works as expected (agent-manager-api-app)
  • Added unit tests (for new features)
  • Stress test for affected components
  • Decoder/Rule tests
    • Added unit testing files ".ini"
    • runtests.py executed without errors

@jnasselle jnasselle self-assigned this Apr 1, 2022
@jnasselle jnasselle force-pushed the 12660-windows-binaries-info branch 2 times, most recently from c64051f to dc82ccc Compare April 1, 2022 20:41
- Add detailed information for Windows agent binaries and libraries.
- Add version.rc file with default values and allowing to set some of
them by defines
- Add version.rc customization by bump_version.sh
@jnasselle jnasselle force-pushed the 12660-windows-binaries-info branch from dc82ccc to 7e9d0c5 Compare April 5, 2022 02:29
src/win32/version.rc Outdated Show resolved Hide resolved
@Dwordcito Dwordcito merged commit 61f3eeb into dev-debug-symbols Apr 5, 2022
@Dwordcito Dwordcito deleted the 12660-windows-binaries-info branch April 5, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add resource data to windows binaries in order simplify symbols relation
4 participants