Adding versioning info to Windows binaries to fix the MSI upgrade #19397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pereyra-m
force-pushed
the
bug/19379-windows-msi-installer
branch
6 times, most recently
from
34e892a
to
ce2e1d0
Compare
pereyra-m
force-pushed
the
bug/19379-windows-msi-installer
branch
7 times, most recently
from
3872aae
to
b69eff6
Compare
pereyra-m
force-pushed
the
bug/19379-windows-msi-installer
branch
from
b69eff6
to
0a3051d
Compare
pereyra-m
force-pushed
the
bug/19379-windows-msi-installer
branch
from
7bbe5f9
to
24450be
Compare
Dwordcito
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was found that the upgrade fails because the installer has an "omus" (https://learn.microsoft.com/en-us/windows/win32/msi/reinstallmode) behavior by default, and after restoring the files to their previous state (without version), the
.msiinstaller ignores them after deleting the previous ones.It was decided that modifying this setting in the installer might be dangerous, so the version info was added.
These changes were taken from #13017 (thank you @jnasselle ).
Tests
The details are now filled
A future
v5.0.0-1was simulated with the bump version script, and the upgrade was successfull