Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete implications of cluster disabled option from framework code #13561

Merged

Conversation

mcarmona99
Copy link
Contributor

@mcarmona99 mcarmona99 commented May 23, 2022

Related issue
#13382

Description

This pull request closes #13382.

I have removed all references to the disabled cluster configuration option in this PR. As it was said in the related epic issue, the Wazuh cluster will always be enabled by default so the framework implications are no longer needed.

I have also updated framework unit tests, API integration tests, and the API specification.

Note that modules like stats, manager, etc have hardcoded variables like the following:

cluster_enabled = True
node_id = get_node().get('node')

I have done this as this part of the code will be refactored when solving the issue #13408.

@mcarmona99 mcarmona99 self-assigned this May 23, 2022
@mcarmona99 mcarmona99 linked an issue May 23, 2022 that may be closed by this pull request
13 tasks
@mcarmona99 mcarmona99 changed the title Delete cluster disabled implications from framework code Delete implications of cluster disabled option from framework code May 23, 2022
@Selutario Selutario requested review from Selutario and removed request for Selutario May 24, 2022 06:41
@mcarmona99 mcarmona99 force-pushed the feature/13382-framework-cluster-enabled branch from d81b643 to a336cb4 Compare May 30, 2022 14:15
Copy link
Contributor

@vicferpoy vicferpoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Selutario Selutario merged commit bb22584 into dev-7108-cluster-by-default May 31, 2022
@Selutario Selutario deleted the feature/13382-framework-cluster-enabled branch May 31, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove framework code for non-cluster setups
3 participants