Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add empty string check before cleaning agents artifacts. #13892

Merged
merged 8 commits into from
Sep 1, 2022
Merged

Add empty string check before cleaning agents artifacts. #13892

merged 8 commits into from
Sep 1, 2022

Conversation

MiguelazoDS
Copy link
Member

@MiguelazoDS MiguelazoDS commented Jun 16, 2022 •
edited
Loading

Related issue
#13875

Description

This PR fixes the deletion of the diff directory due to an empty agent name.

image

  • Compilation without warnings in every supported platform
    • Linux
  • Source installation
  • Source upgrade
  • Review logs syntax and correct language
  • Memory tests for Linux
    • Scan-build report
  • Added unit tests (for new features)

@MiguelazoDS MiguelazoDS self-assigned this Jun 16, 2022
@MiguelazoDS MiguelazoDS linked an issue Jun 16, 2022 that may be closed by this pull request
Wazuh-db could delete the 'queue/diff' directory completely #13875
Closed
@MiguelazoDS MiguelazoDS force-pushed the dev-13875-diff-directory-deleted branch from b0bd8ca to 79030f6 Compare June 16, 2022 14:52
@MiguelazoDS MiguelazoDS changed the title Don't attempt to clean agents artifacts if the name is an empty string Add empty string check before cleaning agents artifacts. Jun 19, 2022
@MiguelazoDS MiguelazoDS removed their assignment Jun 19, 2022
@pereyra-m pereyra-m marked this pull request as ready for review June 23, 2022 02:40
jnasselle
jnasselle reviewed Jun 24, 2022
View reviewed changes
src/shared/read-agents.c Outdated Show resolved Hide resolved
src/wazuh_db/helpers/wdb_global_helpers.c Outdated Show resolved Hide resolved
src/wazuh_modules/wm_database.c Outdated Show resolved Hide resolved
src/wazuh_modules/wm_database.c Outdated Show resolved Hide resolved
src/unit_tests/wazuh_modules/database/test_wm_database.c Outdated Show resolved Hide resolved
src/unit_tests/wazuh_modules/database/test_wm_database.c Outdated Show resolved Hide resolved
@pereyra-m pereyra-m added the type/bug/non production Bug in a non-production branch label Jun 29, 2022
@MiguelazoDS MiguelazoDS mentioned this pull request Jun 29, 2022
Closed
7 tasks
@pereyra-m pereyra-m requested a review from jnasselle June 29, 2022 15:25
@pereyra-m pereyra-m force-pushed the dev-13875-diff-directory-deleted branch from d7c69fc to 6a4471d Compare June 29, 2022 17:42
HanesSciarrone
HanesSciarrone approved these changes Jul 1, 2022
View reviewed changes
src/shared/read-agents.c Outdated Show resolved Hide resolved
src/unit_tests/wazuh_modules/database/test_wm_database.c Outdated Show resolved Hide resolved
@MiguelazoDS MiguelazoDS mentioned this pull request Aug 29, 2022
Closed
8 tasks
@MiguelazoDS MiguelazoDS force-pushed the dev-13875-diff-directory-deleted branch from 1aa1966 to cc42bff Compare August 30, 2022 14:00
@jmv74211
Copy link
Contributor

jmv74211 commented Sep 1, 2022

QA review

@Dwordcito Dwordcito merged commit c001e5f into 4.4 Sep 1, 2022
@Dwordcito Dwordcito deleted the dev-13875-diff-directory-deleted branch September 1, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pereyra-m pereyra-m pereyra-m left review comments

@jnasselle jnasselle jnasselle approved these changes

@jftuduri jftuduri jftuduri approved these changes

@Dwordcito Dwordcito Dwordcito approved these changes

@HanesSciarrone HanesSciarrone HanesSciarrone approved these changes

Assignees

@MiguelazoDS MiguelazoDS

@pereyra-m pereyra-m

Labels
type/bug/non production Bug in a non-production branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wazuh-db could delete the 'queue/diff' directory completely
7 participants
@MiguelazoDS @jmv74211 @jnasselle @jftuduri @Dwordcito @HanesSciarrone @pereyra-m