Improved framework functions used by MITRE API endpoints #14208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
vicferpoy
suggested changes
Jul 12, 2022
vicferpoy
suggested changes
Jul 12, 2022
vicferpoy
suggested changes
Jul 12, 2022
Co-authored-by: Víctor Fernández Poyatos <victor.f.poyatos@wazuh.com>
davidjiglesias
approved these changes
Jul 19, 2022
davidjiglesias
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #14167.
In this pull request, I have improved all the MITRE framework functions. There is more information about the new design in the related issue's comments.
Apart from the time improvements, I have also reviewed the request_slice values, reviewed the queries to improve the optimal request_slice for relational queries, made profiling, and removed timeouts.
New total times (API integration tests environment, CI hosts)
Specs: 4 GB RAM and 2 CPU cores (Wazuh deployment in a Docker environment). Specs between the minimum and the recommended for a Wazuh manager.
As we can see there is no need to use custom timeouts.