-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify AWS tests to use isolated resources #23419
Modify AWS tests to use isolated resources #23419
Conversation
4b33cc7
to
e495436
Compare
083255b
to
6587a67
Compare
1e4df04
to
df2280e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job!
I left you with some small improvements to make.
...on/test_aws/data/test_cases/only_logs_after_test_module/cases_cloudwatch_multiple_calls.yaml
Outdated
Show resolved
Hide resolved
s3_client (boto3.resources.base.ServiceResource): S3 client used to manage the bucket resources. | ||
ec2_client (Service client instance): EC2 client to manage VPC resources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't these the same type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The instanced objects are from different classes. The first one is a ServiceResource (called client
since it has a similar use as a client) and the second is a Service client instance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @fdalmaup 🎉 I added just one question
bac68b6
to
c8cf993
Compare
4637420
to
45dd6ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4c0da89
into
17788-aws-integration-test-migration-and-refactor
Description
Finished adapting the AWS module integration tests to use isolated resources created and deleted during the execution:
AWS_PROFILE
environment variable)Tests
Note
The failing tests should be modified once the behavior of the AWS module regarding unexistent regions is checked in the #23431 issue.
Important
This PR must be merged along with wazuh/qa-integration-framework#25 which contains several modifications to the Framework used for the tests