Fix bug in Windows agent that did not honor buffer's EPS limit #7333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…econd. The call to select() fails with an invalid parameter result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix issue #7304 by replacing the call to
select()withnanosleep(). Paradoxically, we usedselect()looking for cross-platform compatibility. As explained in the issue, Windows does not support callingselect()with the three sets of file descriptor null.Tests
delayprocedure on Solaris 10 (test thatnanosleepis available).delayprocedure on AIX 6.1 (test thatnanosleepis available).