Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unit tests for the os_net library #7595

Merged
merged 15 commits into from
Mar 3, 2021
Merged

Improve unit tests for the os_net library #7595

merged 15 commits into from
Mar 3, 2021

Conversation

javabalm
Copy link
Contributor

@javabalm javabalm commented Feb 23, 2021 •
edited
Loading

Description

Test_os_net rewritten from the original test to test functions individually and be consistent with the purpose of unit tests.

Tests

  • Compilation without warnings in every supported platform
    • Linux
  • Source installation
  • Package installation
  • Memory tests for Linux
    • Valgrind (memcheck and descriptor leaks check)

TomasTurina
TomasTurina reviewed Feb 23, 2021
View reviewed changes
src/unit_tests/os_net/test_os_net.c Outdated Show resolved Hide resolved
src/unit_tests/os_net/test_os_net.c Outdated Show resolved Hide resolved
TomasTurina
TomasTurina reviewed Feb 24, 2021
View reviewed changes
src/unit_tests/wrappers/linux/socket_wrappers.c Outdated Show resolved Hide resolved
src/unit_tests/wrappers/linux/socket_wrappers.h Outdated Show resolved Hide resolved
src/unit_tests/wrappers/linux/socket_wrappers.c Outdated Show resolved Hide resolved
src/unit_tests/wrappers/linux/socket_wrappers.h Outdated Show resolved Hide resolved
@TomasTurina TomasTurina marked this pull request as ready for review February 24, 2021 18:41
TomasTurina
TomasTurina reviewed Mar 2, 2021
View reviewed changes
src/unit_tests/os_net/test_os_net.c Outdated Show resolved Hide resolved
src/unit_tests/os_net/test_os_net.c Outdated Show resolved Hide resolved
@cborla cborla force-pushed the test_os_net branch 2 times, most recently from 2177c3c to 4c872ce Compare March 2, 2021 16:16
TomasTurina
TomasTurina approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@TomasTurina TomasTurina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vikman90 vikman90 changed the title Test os net Improve unit tests for the os_net library Mar 3, 2021
@vikman90 vikman90 added type/test/unit type/enhancement New feature or request labels Mar 3, 2021
@vikman90 vikman90 merged commit bc1d6f8 into master Mar 3, 2021
@vikman90 vikman90 deleted the test_os_net branch March 3, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasTurina TomasTurina TomasTurina approved these changes

@vikman90 vikman90 Awaiting requested review from vikman90

Assignees
No one assigned
Labels
type/enhancement New feature or request type/test/unit
Projects
None yet
Milestone
Sprint 125 - Core/Binary Beasts
Development

Successfully merging this pull request may close these issues.
4 participants
@javabalm @TomasTurina @vikman90 @cborla