-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let wcom execute check-manager-config query. #8357
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Molter73
suggested changes
Apr 26, 2021
antoniomanuelfr
force-pushed
the
8356-avoid-execd-processing-api-request
branch
from
April 28, 2021 11:28
77823c6
to
3a83c19
Compare
Molter73
previously approved these changes
Apr 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Molter73
force-pushed
the
8356-avoid-execd-processing-api-request
branch
from
April 29, 2021 18:35
3a83c19
to
1c8c30e
Compare
Molter73
previously approved these changes
Apr 30, 2021
antoniomanuelfr
force-pushed
the
8356-avoid-execd-processing-api-request
branch
2 times, most recently
from
May 4, 2021 08:04
3e44045
to
d47a8ff
Compare
antoniomanuelfr
force-pushed
the
8356-avoid-execd-processing-api-request
branch
from
May 4, 2021 13:48
d47a8ff
to
d3e1044
Compare
- This commit also enhances the code of wcom_check_manager_config.
antoniomanuelfr
force-pushed
the
8356-avoid-execd-processing-api-request
branch
from
May 10, 2021 08:14
d3e1044
to
127f8a7
Compare
…8535) * Rework manager validation to use wcom instead of execq and execa * Update core manager unit tests and improve coverage * Update SDK manager unit tests
vikman90
approved these changes
May 12, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to avoid
execd
to executecheck-manager-config
andrestart-manager
API requests. Now, these requests that were executed byexecd
will be executed by thewcom
thread. This will avoid the problems described in #7968 once this development is completed.If the
check-manager-config
request is sent to execd after the change, the following error will appear:Closes #8356
Test active response disabled
Test active response enabled
The exception that is raised is because the API was expecting to connect to the
alerts/execa
sockets, which is no longer used and it won't be created.Valgrind report