-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Windows agent upgrade via WPK #9764
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JcabreraC
added
module/upgrade/wpk
module/upgrade
Issue related to the upgrade process
labels
Aug 19, 2021
nmkoremblum
force-pushed
the
9735-fix-WPK-upgrade-windows
branch
from
August 26, 2021 14:32
3c5c50b
to
8742a69
Compare
juliancnn
force-pushed
the
9735-fix-WPK-upgrade-windows
branch
from
August 31, 2021 20:18
8742a69
to
d4f50db
Compare
juliancnn
force-pushed
the
9735-fix-WPK-upgrade-windows
branch
from
September 2, 2021 13:23
f8ff2fc
to
d43129c
Compare
juliancnn
force-pushed
the
9735-fix-WPK-upgrade-windows
branch
4 times, most recently
from
September 2, 2021 20:57
bf421ad
to
22dafd2
Compare
juliancnn
force-pushed
the
9735-fix-WPK-upgrade-windows
branch
2 times, most recently
from
September 6, 2021 19:31
f051879
to
d513844
Compare
nmkoremblum
force-pushed
the
9735-fix-WPK-upgrade-windows
branch
2 times, most recently
from
September 7, 2021 13:30
b205a55
to
31b0946
Compare
juliancnn
force-pushed
the
9735-fix-WPK-upgrade-windows
branch
10 times, most recently
from
September 9, 2021 16:14
3091abc
to
2065669
Compare
juliancnn
force-pushed
the
9735-fix-WPK-upgrade-windows
branch
from
October 5, 2021 19:41
3a7dfa7
to
186dc23
Compare
juliancnn
approved these changes
Oct 6, 2021
nmkoremblum
approved these changes
Oct 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
LGTM ! |
1 similar comment
LGTM ! |
vikman90
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a backup and restore system in case of update failure via WPK in windows.
An update is considered failed when the agent cannot connect to the manager or the ossec-agent.state file does not exist.
Backup process:
Rollback:
Tests
Windows NT 6.0⚠️
Windows 7 x86
Agent 3.5
ossec.log
) are kept.programs and features
.Agent 3.7
ossec.log
) are kept.programs and features
.Agent 3.13
ossec.log
) are kept.programs and features
.Agent 4.0
ossec.log
) are kept.programs and features
.Agent 4.1.5
ossec.log
) are kept.programs and features
.Agent 4.2.1
ossec.log
) are kept.programs and features
.Windows 7 x64
Agent 3.5
ossec.log
) are kept.programs and features
.Agent 4.1.5
ossec.log
) are kept.programs and features
.Agent 4.2.1
ossec.log
) are kept.programs and features
.Windows Server 2008 R2 x64
Agent 3.5
ossec.log
) are kept.programs and features
.Agent 3.13
ossec.log
) are kept.programs and features
.Agent 4.0
ossec.log
) are kept.programs and features
.Agent 4.1
ossec.log
) are kept.programs and features
.Agent 4.2
ossec.log
) are kept.programs and features
.Windows 10 x64
Agent 3.5
ossec.log
) are kept.programs and features
.Agent 3.13
ossec.log
) are kept.programs and features
.Agent 4.0
ossec.log
) are kept.programs and features
.Agent 4.1
ossec.log
) are kept.programs and features
.Agent 4.2
ossec.log
) are kept.programs and features
.Windows 10 x86
Agent 3.5
ossec.log
) are kept.programs and features
.Agent 3.13
ossec.log
) are kept.programs and features
.Agent 4.0
ossec.log
) are kept.programs and features
.Agent 4.1
ossec.log
) are kept.programs and features
.Agent 4.2
ossec.log
) are kept.programs and features
.Windows Server 2016 x64
Agent 3.5
ossec.log
) are kept.tree_3.5.zip
programs and features
.Agent 3.7
ossec.log
) are kept.programs and features
.Agent 3.13
ossec.log
) are kept.programs and features
.Agent 4.0
ossec.log
) are kept.programs and features
.Agent 4.1
ossec.log
) are kept.programs and features
.Agent 4.2
ossec.log
) are kept.programs and features
.Windows 8.1 x64
Agent 3.5
ossec.log
) are kept.programs and features
.Agent 3.13
ossec.log
) are kept.programs and features
.Agent 4.0.4
ossec.log
) are kept.programs and features
.Agent 4.2.0
ossec.log
) are kept.programs and features
.Windows 8.1 x86
Agent 3.5
ossec.log
) are kept.programs and features
.Agent 3.13
ossec.log
) are kept.programs and features
.Agent 4.1.5
ossec.log
) are kept.programs and features
.Agent 4.2.1
ossec.log
) are kept.programs and features
.Windows server 2012 R2 x64
Agent 3.5
ossec.log
) are kept.programs and features
.Agent 3.13
ossec.log
) are kept.programs and features
.Agent 4.0.4
ossec.log
) are kept.programs and features
.Agent 4.1.5
ossec.log
) are kept.programs and features
.Agent 4.2.0
ossec.log
) are kept.programs and features
.Windows server 2012 R2 x64
Agent 3.5
ossec.log
) are kept.programs and features
.Agent 3.13
ossec.log
) are kept.programs and features
.Agent 4.0.4
ossec.log
) are kept.programs and features
.Agent 4.1.5
ossec.log
) are kept.programs and features
.Agent 4.2.0
ossec.log
) are kept.programs and features
.Windows server 2019
Agent 3.5
ossec.log
) are kept.programs and features
.Agent 3.13
ossec.log
) are kept.programs and features
.Agent 4.0.4
ossec.log
) are kept.programs and features
.Agent 4.1.5
ossec.log
) are kept.programs and features
.Agent 4.2.0
ossec.log
) are kept.programs and features
.Windows server 2022
Agent 3.5
ossec.log
) are kept.programs and features
.Agent 3.13
ossec.log
) are kept.programs and features
.Agent 4.0.4
ossec.log
) are kept.programs and features
.Agent 4.1.5
ossec.log
) are kept.programs and features
.Agent 4.2.0
ossec.log
) are kept.programs and features
.