Switch to use transient.el #26
Conversation
|
Thank you for review. Please let me know which of fixes to comments you'd like to see in before merging. |
|
i responded inline to most comments. happy to merge this after making a tiny adjustment. i will experiment with shortening some names later. i'll ping you for feedback once i have a pr for it, if you don't mind. i actually started a branch locally to switch to and then all of a sudden someone else did all the work. 👍😄 |
|
oh one more thing: defining python-pytest-arguments in init.el was a good way to set defaults before. is there a clear replacement for it? if so, it may be worth adding to the readme. |
|
oh yet another thing, maybe use i guess an alias for the obsolete name (defsubst iirc, typing from phone) would help with upgrades. but it's not required and i can do it later. |
`transient` is a replacement to `magit-popup` and even `magit` has already switched to use `transient`. The switch is pretty idiomatic, however there are a few differences. The default layout is slightly different but I didn't try to replace it as the new one seems to match what `magit` is presenting these days. The concept of `:default-action` seems to be gone, so it is not replaced. The `magit-with-pre-popup-buffer` doesn't seem to have an obvious replacement, however the documentation for `transient--original-buffer` suggest that the `transient` is not changing the current buffer.
Sure. Happy to help with it.
Let me see what I can do today.
Perhaps there's some programmatic way, but I'm not aware of it. What I know is |
|
nice, i see you did the rename to |
With transient, an `eval-buffer` is picking up new definition of `python-pytest-dispatch` (the popup).
|
merged, thanks a lot for doing all the hard/boring (choose yourself) work! |
|
Pleasure. It was really nice to work with you! |
Make the ‘-v’ option cycle between nothing, ‘--verbose’, and ‘--verbose --verbose’. This was suggested before (#22 (review)) but wasn't possible at the time of #22 because it seemed impossible due to magit-popup.el limitations. Now that the dispatch menu uses transient.el instead of magit-popup.el (#18, #26), it can be implemented after all
Make the ‘-v’ option cycle between nothing, ‘--verbose’, and ‘--verbose --verbose’. This was suggested before (#22 (review)) but wasn't possible at the time of #22 because it seemed impossible due to magit-popup.el limitations. Now that the dispatch menu uses transient.el instead of magit-popup.el (#18, #26), it can be implemented after all.
Make the ‘-v’ option cycle between nothing, ‘--verbose’, and ‘--verbose --verbose’. This was suggested before (#22 (review)) but wasn't possible at the time of #22 due to magit-popup.el limitations. Now that the dispatch menu uses transient.el instead of magit-popup.el (#18, #26), it can be implemented after all.
Make the ‘-v’ option cycle between nothing, ‘--verbose’, and ‘--verbose --verbose’. This was suggested before (#22 (review)) but wasn't possible at the time of #22 due to magit-popup.el limitations. Now that the dispatch menu uses transient.el instead of magit-popup.el (#18, #26), it can be implemented after all.
transientis a replacement tomagit-popupand evenmagithas already switched to usetransient.This fixes #18.
The switch is pretty idiomatic, however there are a few differences.
The default layout is slightly different but I didn't try to replace it as the new one seems to match what
magitis presenting these days. I think that the new layout resembles more whatmagitis presenting these days, but I don't have any scientific method for that. Happy to work on changing to original layout if this is desired.The concept of
:default-actionseems to be gone, so I did not replace it.The
magit-with-pre-popup-bufferdoesn't seem to have an obvious replacement, however the documentation fortransient--original-buffersuggest that thetransientpopup is not changing the current buffer. I validated that with a check that thecurrent-bufferreturns expectedpytestbuffer while invokingpython-pytestviapython-pytest-popup.