Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make -v cycle between different verbosity settings #27

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

wbolster
Copy link
Owner

@wbolster wbolster commented Aug 4, 2020

Make the ‘-v’ option cycle between nothing, ‘--verbose’, and ‘--verbose --verbose’. This was suggested before (#22 (review)) but wasn't possible at the time of #22 due to magit-popup.el limitations.

Now that the dispatch menu uses transient.el instead of magit-popup.el (#18, #26), it can be implemented after all.

@wbolster wbolster added the enhancement New feature or request label Aug 4, 2020
@wbolster wbolster self-assigned this Aug 4, 2020
@wbolster
Copy link
Owner Author

wbolster commented Aug 4, 2020

@r-zip @pkryger please review 🙏

Make the ‘-v’ option cycle between nothing, ‘--verbose’, and ‘--verbose
--verbose’. This was suggested before
(#22 (review))
but wasn't possible at the time of #22 due to magit-popup.el limitations.

Now that the dispatch menu uses transient.el instead of magit-popup.el
(#18, #26), it can be implemented after all.
Copy link
Contributor

@pkryger pkryger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple 👍

@wbolster wbolster merged commit 88850ab into master Aug 5, 2020
@wbolster wbolster deleted the verbosity-cycling branch August 5, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants