-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PlantUmlDiagrams package and PlantUmlConnection dependency #6946
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: ERROR
Repo link: PlantUmlDiagrams
Results help
Packages added:
- PlantUmlDiagrams
Processing package "PlantUmlDiagrams"
- ERROR: Error downloading repository. HTTP error 404 downloading https://api.github.com/repos/evandrocoan/PlantUmlDiagrams.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: ERROR
Repo link: PlantUmlDiagrams
Results help
Packages added:
- PlantUmlDiagrams
Processing package "PlantUmlDiagrams"
- ERROR: No valid semver tags found at https://github.com/evandrocoan/PlantUmlDiagrams/tags for the package "PlantUmlDiagrams".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: WARNING
Repo link: PlantUmlDiagrams
Results help
Packages added:
- PlantUmlDiagrams
Processing package "PlantUmlDiagrams"
- WARNING: '.no-sublime-package' is defined. Please verify that it is *really* necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: SUCCESS
Repo link: PlantUmlDiagrams
Packages added:
- PlantUmlDiagrams
Processing package "PlantUmlDiagrams"
- All checks passed
@FichteFoll Long story short, there was a hard fork because the two projects are really trying to do different things. Diagram aims to support any diagram-generating package we can include and has a plug-in architecture for that. It also is designed to be self-contained and not leak information to third parties in its default configuration. PlantUmlDiagram is a hard fork. Rewriting the history to cut out bundled binaries has made merges impractical. It also has shifted to PlantUml only and many of the changes are slowly removing the plug-in architecture that was there. Finally, it requires an outside server to operate rather than bundling everything. In terms of a feature comparison, Diagram vs PlantUmlDiagram:
I really consider them to be separate products, with separate goals, optimized for different use cases. We share patches where convenient, but they're firmly diverged with firmly different feature sets. While there is significant overlap, I wouldn't say they're much worse than the overlap you find in some of the PEP8 linters and the like. |
never sends any of your diagram code off of your machine vs sends your
diagram code to third-parties by default
I got to remove that from my fork by changing the default server URL.
Therefore, it will depend on the user adding the standard PlantUml server
URL, or creating a local server and adding its URL or downloading the
PlantUml jar and setting up the path to it on the settings file.
On my computer, I have a local server running. I also recently added a
feature to generate the diagram while the user type.
|
Thanks, @jvantuyl. That explanation was insanely useful. |
@evandrocoan could you fix the merge conflict, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: SUCCESS
Repo link: PlantUmlDiagrams
Packages added:
- PlantUmlDiagrams
Processing package "PlantUmlDiagrams"
- All checks passed
ab89cb4
to
f5e9d08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: SUCCESS
Repo link: PlantUmlDiagrams
Packages added:
- PlantUmlDiagrams
Processing package "PlantUmlDiagrams"
- All checks passed
f5e9d08
to
72fb178
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: SUCCESS
Repo link: PlantUmlDiagrams
Packages added:
- PlantUmlDiagrams
Processing package "PlantUmlDiagrams"
- All checks passed
I forked https://github.com/jvantuyl/sublime_diagram_plugin to https://github.com/evandrocoan/PlantUmlDiagrams adding a server dependency https://github.com/evandrocoan/PlantUmlConnection and rewrote the whole git history removing all the java binary files which have been added, reducing the repository size from
22.49 MB
to204 KB
. So, now I cannot open a pull request to the original author because git points out:If @jvantuyl would like to receive such changes, he would have to override his master branch with mine. If he do not like that, I would like to add this as an another package under a new name. Otherwise I can close this pull request.
On this fork I already manually merged the pull request from @overlord pending for his repository:
I also fix jvantuyl/sublime_diagram_plugin#60 (Error Processing Diagram) the default example not compiling, also adding to output the error message from the
Plantuml
software.This version now first attempts to contact the webserver accordingly to the new settings: