Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding tabindex to logo and search field #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

adding tabindex to logo and search field #72

wants to merge 1 commit into from

Conversation

jamiewilson
Copy link

First tab to search, second tab to logo/home link, third to next anchor, currently first link in the nav

@wbond
Copy link
Owner

wbond commented Mar 29, 2016

Thanks for taking the time to suggest from improvements!

The opacity transition is currently being used (https://github.com/wbond/packagecontrol.io/blob/master/app/css/package.scss#L7-L13). Try navigating from a package detail page to the homepage. Also try hovering over the logo on a package detail page.

Setting the tab index should be good.

Generally I'm not a huge fan of overriding the outline, but I haven't looked to see how this specific example functions.

@jamiewilson jamiewilson changed the title Adding tabindex and styling focused states adding tabindex to logo and search field Mar 29, 2016
@jamiewilson
Copy link
Author

Cool. Thanks for pointing that out. Somehow I missed that opacity usage!

I just removed the styling, so feel free to merge this for the tabindex additions, but if it's easier to add them yourself, no worries. Just one of those things I always find myself doing when I come to search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants