[ELASTICSEARCH-FIRST] Enable Elasticsearch for new wikis #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toban
force-pushed
the
elasticsearch-setting
branch
9 times, most recently
from
556f41d
to
ebc34ff
Compare
toban
changed the title
toban
force-pushed
the
elasticsearch-setting
branch
2 times, most recently
from
7570715
to
0383f1c
Compare
|
The actual search for Lexemes still isn't working locally in the mediawiki repo. We are probably missing some configuration that needs to be added. |
|
Should have started in the other end on this epic, seems elasticsearch does not need any special updating to handle lexeme. |
toban
changed the title
|
this is being re-written not to use the observer |
toban
force-pushed
the
elasticsearch-setting
branch
from
34eada0
to
0c64d61
Compare
toban
commented
Aug 13, 2021
toban
force-pushed
the
elasticsearch-setting
branch
2 times, most recently
from
caca26f
to
43c71b5
Compare
toban
changed the title
toban
force-pushed
the
elasticsearch-setting
branch
2 times, most recently
from
65180d1
to
d57042c
Compare
toban
changed the title
lucaswerkmeister
approved these changes
Aug 18, 2021
toban
force-pushed
the
elasticsearch-setting
branch
from
d57042c
to
826e479
Compare
toban
changed the title
This adds wwExtEnableElasticSearch to new wikis and dispatches a job to initialize the index and enable the feature. Lexeme and Wikibase terms end up in the same index so we do not need to take this into consideration.
toban
force-pushed
the
elasticsearch-setting
branch
from
826e479
to
74d29b9
Compare
lucaswerkmeister
approved these changes
Aug 19, 2021
addshore
changed the title
addshore
reviewed
Aug 24, 2021
This is required in-order for the job to to be able to run.
addshore
requested changes
Sep 1, 2021
- Adds some more tests to the failure conditions, each one should result in the setting being disabled. - refactors the cirrus search base name to be the wikiDB instead of domain. - bumps the timeout to 60 seconds
toban
force-pushed
the
elasticsearch-setting
branch
from
5cf8d32
to
4973dea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables elasticsearch for new wikis through the ElasticSearchIndexInit job.
Lexemes and Items end up in the same index so no special treatment should be needed when this setting is enabled but probably needs wbstack/mediawiki#121 to be deployed before.