[STANDALONE ]Add K8s ingress deletion job #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This turned out to be quite the blackbox, tried setting up minikube for testing but wouldn't work without somekind of proxy thing to make them talk between docker <-> minikube which feels to be a step too far. Do we just trust this api to work?
toban
commented
Aug 18, 2021
| $wiki = Wiki::factory()->create( [ 'deleted_at' => null ] ); | ||
| WikiManager::factory()->create(['wiki_id' => $wiki->id, 'user_id' => $user->id]); | ||
|
|
||
| $mockJob = $this->createMock(Job::class); |
There was a problem hiding this comment.
Is this how you are supposed to test these failure functions? It seems to work but this is the first time any of these failure things get tested afaik.
There was a problem hiding this comment.
Tried getting the FailedJobProviderInterfaceby using the app->make function which seemed to work, however in the tests nothing seems to get written to the database(also tried adding the Dispatchable interface to the job and use dispatchSync). Does that happen in production though?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turned out to be quite the blackbox, tried setting up minikube for
testing but wouldn't work without somekind of proxy thing to make them
talk between docker <-> minikube which feels to be a step too far. Do we
just trust this api to work?