Inject CurlRequest in handle on ElasticSearchIndexInit #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toban
changed the title
Jobs apparently don't inject dependencies through the constructor but rather the handle function. In case of an interface being used this will also require a explicit binding in the app service provider. This changes that, and adds a test to try this out.
toban
force-pushed
the
patch-elasticsearch-init
branch
from
567bb84
to
0c080f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jobs apparently don't inject dependencies through the constructor but
rather the handle function. In case of an interface being used this will
also require a explicit binding in the app service provider.
This changes that, and adds a test to try this out.